Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macros so that they can easily be used with use #432

Closed
kjvalencik opened this issue Sep 4, 2019 · 0 comments
Closed

Update macros so that they can easily be used with use #432

kjvalencik opened this issue Sep 4, 2019 · 0 comments

Comments

@kjvalencik
Copy link
Member

kjvalencik commented Sep 4, 2019

Some of the macros call other internal only macros. This can make importing them somewhat unintuitive and verbose.

use neon::{class_definition, declare_types, impl_managed, register_module};

This likely needs two changes:

  • Add declare_types and register_module to neon::prelude
  • Make class_definition and impl_managed local inner macros

https://doc.rust-lang.org/edition-guide/rust-2018/macros/macro-changes.html#macros-using-local_inner_macros
rust-lang/rust#51496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant