Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture read from node-gyp incorrectly #490

Closed
dbkr opened this issue Feb 18, 2020 · 0 comments · Fixed by #491
Closed

Architecture read from node-gyp incorrectly #490

dbkr opened this issue Feb 18, 2020 · 0 comments · Fixed by #491

Comments

@dbkr
Copy link
Contributor

dbkr commented Feb 18, 2020

https://github.com/neon-bindings/neon/blob/master/crates/neon-sys/build.rs#L96 reads the architecture from node-gyp configure, but the value printed is just the architecture that node is running on, not the target architecture (https://github.com/nodejs/node-gyp/blob/3555ff4f0031f067bda9a49cbb2dbe6c04f4b5c7/bin/node-gyp.js#L45).

This means that building on an architecture other than that of the host machine's node binary will fail because the final link will use the node library path for the wrong architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant