Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic: fix the attach/detach and add python tests for branching #1898

Closed
stepashka opened this issue Jun 7, 2022 · 2 comments
Closed

Epic: fix the attach/detach and add python tests for branching #1898

stepashka opened this issue Jun 7, 2022 · 2 comments
Assignees
@LizardWizzard
Labels
c/storage/pageserver Component: storage: pageserver f/branching Feature: branching t/Epic Issue type: Epic
Milestone
2022/07

Comments

@stepashka
Copy link
Member

stepashka commented Jun 7, 2022 •
edited
Loading

attach and detach commands are implemented per timeline
this is flexible, because we can have different timelines served on different pageservers
OTOH to properly handle a branch on a pageserver, pageserver needs to be aware of the other timelines, e.g. for GC to not mess things up

shall we attach/detach the whole tenant on pageserver?

does this depend on the on-demand download from s3?
@stepashka stepashka added c/storage/pageserver Component: storage: pageserver t/Epic Issue type: Epic f/branching Feature: branching labels Jun 7, 2022
@LizardWizzard LizardWizzard self-assigned this Jun 8, 2022
@LizardWizzard LizardWizzard mentioned this issue Jun 10, 2022
Open
@stepashka stepashka added this to the 2022/07 milestone Jul 4, 2022
@LizardWizzard
Copy link
Contributor

#1936 is now merged, attach and detach now handle tenant as a whole

gc tests for branching are tracked in #1899. @stepashka should we close this?

@hlinnaka
Copy link
Contributor

hlinnaka commented Jul 8, 2022

#1936 is now merged, attach and detach now handle tenant as a whole

gc tests for branching are tracked in #1899. @stepashka should we close this?

Yeah, let's close this

@hlinnaka hlinnaka closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LizardWizzard LizardWizzard

Labels
c/storage/pageserver Component: storage: pageserver f/branching Feature: branching t/Epic Issue type: Epic
Projects
None yet
Milestone
2022/07
Development

No branches or pull requests
3 participants
@hlinnaka @stepashka @LizardWizzard