Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: expand tests that use branching #1900

Closed
stepashka opened this issue Jun 7, 2022 · 2 comments
Closed

Epic: expand tests that use branching #1900

stepashka opened this issue Jun 7, 2022 · 2 comments
Labels
c/storage/pageserver Component: storage: pageserver c/storage Component: storage f/branching Feature: branching t/Epic Issue type: Epic

Comments

@stepashka
Copy link
Member

No description provided.

@stepashka stepashka added t/Epic Issue type: Epic f/branching Feature: branching c/storage Component: storage labels Jun 7, 2022
@kelvich
Copy link
Contributor

kelvich commented Jul 5, 2022

I don't think that e2e tests are the right place for expanded tests for branches. At first, those tests already exist https://github.com/neondatabase/cloud/blob/main/tests_e2e/tests/test_project.py#L400 At second, I think e2e tests are to test integrations and basic error-out scenarios, not to test feature corner cases. IMO it is better to expand branching tests suite around the pageserver itself -- tests would be fester and they'll have more access to the internal state (files, sizes, manual GC runs, etc).

Let's rename this epic? =)

@kelvich kelvich added the c/storage/pageserver Component: storage: pageserver label Jul 5, 2022
@kelvich kelvich changed the title Epic: expand e2e tests that use branching Epic: expand tests that use branching Jul 5, 2022
@kelvich
Copy link
Contributor

kelvich commented Jul 5, 2022

killed in favor of #1899

@kelvich kelvich closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/pageserver Component: storage: pageserver c/storage Component: storage f/branching Feature: branching t/Epic Issue type: Epic
Projects
None yet
Development

No branches or pull requests

2 participants