Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant configuration is modified even if file saving fails #3472

Closed
koivunej opened this issue Jan 27, 2023 · 1 comment · Fixed by #3534
Closed

Tenant configuration is modified even if file saving fails #3472

koivunej opened this issue Jan 27, 2023 · 1 comment · Fixed by #3534
Labels
c/storage/pageserver Component: storage: pageserver

Comments

@koivunej
Copy link
Member

Noted by @problame in #3446 (comment)

Relevant code:

pub async fn update_tenant_config(
conf: &'static PageServerConf,
tenant_conf: TenantConfOpt,
tenant_id: TenantId,
) -> anyhow::Result<()> {
info!("configuring tenant {tenant_id}");
let tenant = get_tenant(tenant_id, true).await?;
tenant.update_tenant_config(tenant_conf);
let tenant_config_path = conf.tenant_config_path(tenant_id);
Tenant::persist_tenant_config(&tenant.tenant_id(), &tenant_config_path, tenant_conf, false)?;
Ok(())
}

@koivunej koivunej added the c/storage/pageserver Component: storage: pageserver label Jan 27, 2023
@koivunej
Copy link
Member Author

This did have the added benefit that we were able to modify some pitr_cutoffs recently on disk full situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant