Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI breaks and CSS emptied when you do set-AdfsRelyingPartyWebTheme -Logo #135

Closed
hareeqi opened this issue Dec 31, 2020 · 2 comments
Closed
Labels

Comments

@hareeqi
Copy link

hareeqi commented Dec 31, 2020

Hello

We noticed whenever we run the command "set-AdfsRelyingPartyWebTheme" and only give it RP name and logo, it removes the CSS in the following function in when i inspected the page source


function RemoveADFSHtmlHeader()
{
   var title = document.getElementById('mfaGreetingDescription');
   if (title)
   {
      title.style.display = "none";
   }
   SetIllustrationImage("");
   document.getElementById('companyLogo').src = "/adfs/portal/logo/logo.png?id=2159E08337BE5B92300FF0AECEFEDFDB1AACBE69B51591141E5C71B010444594&rp=b51544ff-0e49-eb11-a086-005056b3b676";
   document.getElementsByTagName('link')[0].href = "";
   return true;
}

primarily the issue in

document.getElementsByTagName('link')[0].href = "";

which can be traced in the file

Neos.IdentityServer.MultiFactor.BasePresentation.cs

The command we excuted in ADFS is

set-AdfsRelyingPartyWebTheme -TargetRelyingPartyName "bill" -Logo @{path="C:\themes\logo.png"}
@redhook62 redhook62 added the bug label Dec 31, 2020
@redhook62
Copy link
Member

redhook62 commented Dec 31, 2020

@hareeqi

Thank you !

New Release 3.0.2101.0

Don't forget if necessary to launch Reset-MFAThemesList

@hareeqi
Copy link
Author

hareeqi commented Dec 31, 2020

wow that was amazingly fast, thank you so much, tremendous effort and happy new year :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants