Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 BUG: Neos backend throws error on discarding newly created document node #4024

Closed
1 task done
ahaeslich opened this issue Jan 31, 2023 · 4 comments
Closed
1 task done

Comments

@ahaeslich
Copy link
Member

ahaeslich commented Jan 31, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

If I create a new document node and immediately discard the change, the following error is thrown:

TODO: SITE NOT FOUND; should not happen (for address NodeAddress[contentStream=2085e25a-107c-4fed-8cf0-4a5ac75595c2, dimensionSpacePoint={"language":"en"}, nodeAggregateIdentifier=c4eb7c78-2f5d-48b5-99c8-4ffd04ab0b5c, workspaceName=user-xyz]

On the other hand: discarding changes relating to a published document node leads to no error.

Expected Behavior

As a user, I would like to be able to discard document nodes without publishing them first.

Steps To Reproduce

  1. Create a new page
  2. Discard changes immediately without publishing while having the new page selected

Environment

- Flow: 8.2-dev
- Neos: 9.0-dev
- PHP: 8.1

Anything else?

No response

@nezaniel
Copy link
Member

This seems to be UI related... if the creation of the document you're currently on is discarded, there is no redirect feedback being sent

I see two solutions here:

  • enhance the request by adding context information "WHERE have the nodes been discarded and is that location still available afterwards
  • catch the "missing site" error properly and redirect to the site node matching the request URI

wdyt?

@ahaeslich
Copy link
Member Author

By WHERE you think of the parent node(s)? Wouldn't we need to check which is the next parent that is not included in the discard process? And can the UI provide this context information?

@skurfuerst
Copy link
Member

I think I have some idea what's happening here :) Will provide a PR soon.

@kitsunet
Copy link
Member

Works for me today, closing as it seems to be solved with the mentioned PRs

@github-project-automation github-project-automation bot moved this from Prioritized 🔥 to Done ✅ in Neos 9.0 Release Board Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants