host: set self.name for _on_error_event

fix #425

Author: justinmk

pynvim/plugin/host.py

@@ -59,6 +59,7 @@ def _on_error_event(self, kind, msg):
         errmsg = "{}: Async request caused an error:\n{}\n".format(
             self.name, decode_if_bytes(msg))
         self.nvim.err_write(errmsg, async_=True)
+        return errmsg
 
     def start(self, plugins):
         """Start listening for msgpack-rpc requests and notifications."""
@@ -177,9 +178,9 @@ def _load(self, plugins):
 
         kind = ("script-host" if len(plugins) == 1 and has_script
                 else "rplugin-host")
-        self.nvim.api.set_client_info(
-            *get_client_info(kind, 'host', host_method_spec),
-            async_=True)
+        info = get_client_info(kind, 'host', host_method_spec)
+        self.name = info[0]
+        self.nvim.api.set_client_info(*info, async_=True)
 
     def _unload(self):
         for path, plugin in self._loaded.items():

test/test_events.py

@@ -28,6 +28,13 @@ def test_sending_notify(vim):
     assert vim.eval('g:data') == 'xyz'
 
 
+def test_async_error(vim):
+    # Invoke a bogus Ex command via notify (async).
+    vim.command("lolwut", async_=True)
+    event = vim.next_message()
+    assert event[1] == 'nvim_error_event'
+
+
 def test_broadcast(vim):
     vim.subscribe('event2')
     vim.command('call rpcnotify(0, "event1", 1, 2, 3)')

test/test_host.py

@@ -9,3 +9,15 @@ def test_host_clientinfo(vim):
     assert 'remote' == vim.api.get_chan_info(vim.channel_id)['client']['type']
     h._load([])
     assert 'host' == vim.api.get_chan_info(vim.channel_id)['client']['type']
+
+
+# Smoke test for Host._on_error_event(). #425
+def test_host_async_error(vim):
+    h = Host(vim)
+    h._load([])
+    # Invoke a bogus Ex command via notify (async).
+    vim.command("lolwut", async_=True)
+    event = vim.next_message()
+    assert event[1] == 'nvim_error_event'
+    assert 'rplugin-host: Async request caused an error:\nboom\n' \
+           in h._on_error_event(None, 'boom')

test/test_vim.py

@@ -226,7 +226,7 @@ def test_cwd(vim, tmpdir):
    return a.nvim_buf_line_count(buf)
 end
 
-pynvimtest = {setbuf=setbuf,getbuf=getbuf}
+pynvimtest = {setbuf=setbuf, getbuf=getbuf}
 
 return "eggspam"
 """
@@ -235,7 +235,7 @@ def test_cwd(vim, tmpdir):
 def test_lua(vim):
     assert vim.exec_lua(lua_code, 7) == "eggspam"
     assert vim.lua.pynvimtest_func(3) == 10
-    testmod = vim.lua.pynvimtest
+    lua_module = vim.lua.pynvimtest
     buf = vim.current.buffer
-    testmod.setbuf(buf, ["a", "b", "c", "d"], async_=True)
-    assert testmod.getbuf(buf) == 4
+    lua_module.setbuf(buf, ["a", "b", "c", "d"], async_=True)
+    assert lua_module.getbuf(buf) == 4