fix(asyncio): close child_watcher before the main loop is closed #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @pierreganty can you please test if this PR fixes your issue in #555? To checkout a PR: git clone https://github.com/neovim/pynvim
cd pynvim
git fetch origin pull/556/head
git checkout FETCH_HEAD
pip install -e .and then run neovim (make sure you have a proper python3 host on which this devel version of pynvim is installed). |
|
I have tried and made sure it uses pynvim Version: 0.5.1.dev0 (I followed your clear instructions) but the behavior is the same: the output gets flooded with the same messages as described in #555. |
|
Closing because this does not fix the issue. see #555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix #555.
TODO: