Extending TanukiKit for CI Builds (experiment)

[tiferrei]

As an experiment I was trying to extend TanukiKit to get the builds for a project, the API structure for it is as follows:

• All builds from project:
  /projects/(the id of the project)/builds
  This gets a JSON array with all the builds, pretty similar to getting the project list. Example response:

- To get a specific build from the project: `/projects/(the id of the project)/builds/(the id of the specific build)` This gets a JSON with the info from the build. Example response:

Due to the similar response to a projects get, I tried to adapt it to get the builds, here is the code I have tried:

import Foundation
import RequestKit

@objc public class apiBuildClass: NSObject {
    public let id: Int
    public let user: apiUserClass
    public var status: String?
    public var stage: String?
    public var ref: String?
    public var tag: Bool?
    public var coverage: Double?
    public var createdAt: String?
    public var startedAt: String?
    public var finishedAt: String?

    public init(_ json: [String: AnyObject]) {
        user = apiUserClass(json["user"] as? [String: AnyObject] ?? [:])
        if let id = json["id"] as? Int {
            self.id = id
            status = json["status"] as? String
            stage = json["stage"] as? String
            ref = json["ref"] as? String
            tag = json["tag"] as? Bool
            coverage = json["coverage"] as? Double
            createdAt = json["created_at"] as? String
            startedAt = json["started_at"] as? String
            finishedAt = json["finished_at"] as? String
        } else {
            id = -1
        }
    }
}

public extension TanukiKit {

    /**
     Fetches the Builds for the specified Project
     - parameter Project: The Project to get the builds from.
     - parameter Build: The specific build to get, if nil, gives a list of all the builds available.
     - parameter completion: Callback for the outcome of the fetch.
     */

    public func builds(project: String, build: String, completion: (response: Response<[apiBuildClass]>) -> Void) {
        let router = BuildRouter.ReadProjectBuilds(configuration, project, build)
        router.loadJSON([[String: AnyObject]].self) { json, error in
            if let error = error {
                completion(response: Response.Failure(error))
            }
            if let json = json {
                let repos = json.map { apiBuildClass($0) }
                completion(response: Response.Success(repos))
            }
        }
    }
}

// MARK: Router

enum BuildRouter: Router {
    case ReadProjectBuilds(Configuration, String, String)

    var configuration: Configuration {
        switch self {
        case .ReadProjectBuilds(let config, _, _): return config
        }
    }

    var method: HTTPMethod {
        return .GET
    }

    var encoding: HTTPEncoding {
        return .URL
    }

    var params: [String: String] {
        switch self {
        case .ReadProjectBuilds(_, let project, let build):
            return ["project": project, "build": build]
        }
    }

    var path: String {
        switch self {
        case .ReadProjectBuilds:
            return "/projects/\(params["project"])/builds/\(params["build"])"
        }
    }
}

And this should work by calling it using:

TanukiKit(config).builds("2", build: "47") { response in
            switch response {
            case .Success(let apiBuild):
                print("Number of builds: \(apiBuild.count)")
            case .Failure(let error):
                print("OOPS: \(error)")
                authFailedWarning(self)
            }
        }

Everything builds and compiles perfectly, the public function builds is recognised but nothing outputs when I run it, not even the error. Can you give me hand on this @pietbrauer?

Thanks!

[pietbrauer]

Why not open a PullRequest? Much easier than an issue as I could comment on the code.

[tiferrei]

Of course, just a second and I'll create the pull request

[pietbrauer]

Cool, closing this one.