Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to integrate MCMC strategy into NeRFStudio? #367

Open
yt2639 opened this issue Aug 23, 2024 · 1 comment
Open

Any plan to integrate MCMC strategy into NeRFStudio? #367

yt2639 opened this issue Aug 23, 2024 · 1 comment

Comments

@yt2639
Copy link

yt2639 commented Aug 23, 2024

Hii, is there any plan to integrate MCMC strategy into NeRFStudio's splatfacto? I've tried myself but it seems not working. I essentially add MCMCStrategy.step_post_backward link in trainer.py between self.grad_scaler.scale(loss).backward() link and self.optimizers.optimizer_scaler_step_some(self.grad_scaler, needs_step) link. Additionally, I commented out the after_train and refinement_after operations.

However, the results are pretty weird. I understand MCMC is working well with gsplat code base so I am wondering if there is any plan to integrate MCMC into nerfstudio's code base?

Thanks!

@brentyi
Copy link
Collaborator

brentyi commented Aug 24, 2024

This PR from @jb-ye is relevant: nerfstudio-project/nerfstudio#3376
@kerrj also has a similar branch here for moving to the strategy API: https://github.com/nerfstudio-project/nerfstudio/tree/splatfacto-refactor

My impression of the likely outcome is that MCMC will be added as an option once we move over to gsplat's strategy API, but it won't be enabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants