Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback rewind has edge cases #292

Open
brentyi opened this issue Sep 29, 2024 · 0 comments
Open

Playback rewind has edge cases #292

brentyi opened this issue Sep 29, 2024 · 0 comments

Comments

@brentyi
Copy link
Collaborator

brentyi commented Sep 29, 2024

Incremental updates to scene node properties (visibility, position, point cloud size, etc) aren't correctly reset when we rewind:

if (value < playbackMutable.current.currentTime) {
// Going backwards is more expensive...
playbackMutable.current.currentIndex = recording!.loopStartIndex!;
}

The easiest fix is to set playbackMutable.current.currentIndex to 0 instead of the loop start index, but this has performance implications. Needs some thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant