Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a observable with the logic of userSignedIn() method #500

Open
4 of 17 tasks
ArmandoPerdomo opened this issue Mar 22, 2019 · 2 comments
Open
4 of 17 tasks

Create a observable with the logic of userSignedIn() method #500

ArmandoPerdomo opened this issue Mar 22, 2019 · 2 comments

Comments

@ArmandoPerdomo
Copy link

ArmandoPerdomo commented Mar 22, 2019

I'm submitting a...

  • Regression (a behavior that used to work and stopped working in a new release)
  • Bug report
  • Performance issue
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Current behavior

Actually userSignedIn() method can be used when is called only

Expected behavior

userSignedIn can be a observable, this ensures when the data changes to false, subscribers callbacks can be executed

What is the motivation / use case for changing the behavior?

In my app when user logout, is difficult handle with this method

Environment

Angular-Token version: ^7.0.1
Angular version: 7.1.4

Bundler

  • Angular CLI (Webpack)
  • Webpack
  • SystemJS

Browser:

  • Chrome (desktop) version XX
  • Chrome (Android) version XX
  • Chrome (iOS) version XX
  • Firefox version XX
  • Safari (desktop) version XX
  • Safari (iOS) version XX
  • IE version XX
  • Edge version XX
@ArmandoPerdomo ArmandoPerdomo changed the title Create a observable of userSignedIn() method Create a observable with the logic of userSignedIn() method Mar 22, 2019
@neroniaky
Copy link
Owner

Hey @ArmandoPerdomo you could give the RC of 7.1.0 a try, which has this build in.

@ArmandoPerdomo
Copy link
Author

Hey @ArmandoPerdomo you could give the RC of 7.1.0 a try, which has this build in.

I tried, but you have added this feature yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants