Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an application-level method of controlling the animation #83

Closed
vanvoljg opened this issue Jul 15, 2020 · 0 comments · Fixed by #95
Closed

Provide an application-level method of controlling the animation #83

vanvoljg opened this issue Jul 15, 2020 · 0 comments · Fixed by #95
Assignees
Labels
discussion Needs discussion refactor Refactoring code or tech debt repayment

Comments

@vanvoljg
Copy link
Member

Right now, there are no friendly ways to control the animation. There's no standardized means of telling the application to play the next/previous animation, or to change the animation's configuration.

This is especially apparent in lib/xebow_web/live/matrix_live.ex on L71, where there's logic for switching animations duplicated between the live view module and lib/xebow/keyboard.ex.

We'll need to figure out a way to do this. I'm pretty sure it'll involve some refactoring, and will likely touch a couple other issues.

@vanvoljg vanvoljg added refactor Refactoring code or tech debt repayment discussion Needs discussion labels Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Needs discussion refactor Refactoring code or tech debt repayment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant