Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel state should only be removed when shutdown transaction has been confirmed #86

Closed
contrun opened this issue Jun 19, 2024 · 2 comments
Closed

Channel state should only be removed when shutdown transaction has been confirmed #86

contrun opened this issue Jun 19, 2024 · 2 comments

Comments

@contrun
Copy link
Collaborator

contrun commented Jun 19, 2024

Currently channel state is removed immediately after channel state changed to Closed. This is undesirable. We need to wait for the shutdown transaction. Also, sometime user may want to keep channel even if it is finished.

https://github.com/nervosnetwork/cfn-node/blob/f9e79b060f7329309eff752b7485bfacc91a629f/src/ckb/channel.rs#L1085
@contrun contrun moved this to 📋 Backlog in CKB Kanban Jul 5, 2024
@eval-exec
Copy link

Hello, @contrun
Can we change the status of this Kanban to Done now?

@contrun
Copy link
Collaborator Author

contrun commented Jul 10, 2024

Yes. This issue is resolved with #124

@contrun contrun closed this as completed Jul 10, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in CKB Kanban Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@contrun @eval-exec