Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The principle here is to try to avoid
Entity::from_slice
orReader::to_entity
if possible, because they need to allocate and copy memory.Replace
Box<[u8]>
->as_ref
->Reader::from_slice_should_be_ok
->to_entity
withfrom_box_should_be_ok!
, which isfrom_slice_should_be_ok
+into
->new_unchecked
.Replace
Entity::from_slice
->as_reader
withReader::from_slice
.Replace
to_entity
->unpack
withunpack
.