Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double disposal #33

Open
dsyme opened this issue Jun 11, 2015 · 0 comments
Open

Double disposal #33

dsyme opened this issue Jun 11, 2015 · 0 comments

Comments

@dsyme
Copy link
Contributor

dsyme commented Jun 11, 2015

While looking over the code I noticed this. There seems to be a double disposal here and here.

As far as I understand it, if the TryAdvance() returns false, then it is the responsibility of the owner of the iterator to then call Dispose() - the disposal shouldn't be called inside TryAdvance()

This is actually fixed in this work at this point by just deleting the disposal logic in the tryAdvance(), though it could be fixed directly instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant