Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axios has a bug that was resolved in axios 1.2.0 #619

Closed
3 of 4 tasks
SalvatorePreviti opened this issue Nov 28, 2022 · 3 comments
Closed
3 of 4 tasks

axios has a bug that was resolved in axios 1.2.0 #619

SalvatorePreviti opened this issue Nov 28, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@SalvatorePreviti
Copy link

SalvatorePreviti commented Nov 28, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Axios package version 1.0 and 1.1 has a bug that was resolved in latest version of axios.
Using a retry incerceptor causes axios to fail. See softonic/axios-retry#212
Can you update @nestjs/axios to the latest version of axios?

Minimum reproduction code

N/A

Steps to reproduce

Use a retry interceptor like axios-retry with the current version shipped with @nestjs/axios
See softonic/axios-retry#212
See the pull request that fixed the issue: axios/axios#5224

Expected behavior

Latest version of axios included in @nestjs/axios that does not suffer from the bug mentioned in softonic/axios-retry#212

Package version

1.0.0

NestJS version

9.2.0

Node.js version

16.18.1

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@SalvatorePreviti SalvatorePreviti added the bug Something isn't working label Nov 28, 2022
@SalvatorePreviti SalvatorePreviti changed the title axios 1.0.0 has a bug that was resolved in axios 1.2.0 axios has a bug that was resolved in axios 1.2.0 Nov 28, 2022
@SalvatorePreviti
Copy link
Author

Excuse me for asking, but I am blocked from updating until this is solved. Is there any update or ETA? Would be great to have axios as a peer dependency or it updated to the latest version

@micalevisk
Copy link
Member

there's no ETA.

as an workaround, can't you use this: nestjs/nest#10583 (comment)

@kamilmysliwiec
Copy link
Member

Let's track this here #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants