Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axios needs to be updated to 1.2.x #624

Closed
2 of 4 tasks
ctsstc opened this issue Dec 16, 2022 · 1 comment
Closed
2 of 4 tasks

Axios needs to be updated to 1.2.x #624

ctsstc opened this issue Dec 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ctsstc
Copy link

ctsstc commented Dec 16, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Right now axios.isAxiosError will return the following error:

TypeError: Cannot read properties of undefined (reading 'isAxiosError')

There is a ticket around this in the axios repository here:

The problem is fixed by updating axios to 1.2.x

Currently if I update and include axios by hand then I get version missmatching on my typing as explained here:

Argument of type 'import("./node_modules/axios/index").AxiosRequestConfig<any>' is not assignable to parameter of type 'import("./node_modules/@nestjs/axios/node_modules/axios/index").AxiosRequestConfig<any>'.

Minimum reproduction code

axios/axios#5011

Steps to reproduce

No response

Expected behavior

I should be able to call axios.isAxiosError without it saying that axios is undefined.

This is a known bug for axios v1.1.3, and thus axios should be updated to 1.2.x

Package version

1.0.0

NestJS version

9.2.1

Node.js version

16.15.1

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@ctsstc ctsstc added the bug Something isn't working label Dec 16, 2022
@kamilmysliwiec
Copy link
Member

#616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants