Cannot build with Webpack

[hjf]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

When running with nest start, it works as expected. When running with build --webpack, it fails because it cannot find some path. This seems to have been removed by upstream (typestack/class-transformer#563)

Implemented the proposed solution in the link

Minimum reproduction code

https://github.com/hjf/mapped-types-bug

Steps to reproduce

1. yarn
2. yarn build --webpack
3. see error

Expected behavior

It should build with no errors

Package version

1.0.0

Node.js version

14.17.4

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

[micalevisk]

For folks looking this, the error is the following:

ERROR in ./node_modules/@nestjs/mapped-types/dist/type-helpers.utils.js 69:27-63
Module not found: Error: Can't resolve 'class-transformer/storage' in '/tmp/mapped-types-bug/node_modules/@nestjs/mapped-types/dist'
resolve 'class-transformer/storage' in '/tmp/mapped-types-bug/node_modules/@nestjs/mapped-types/dist'
  Parsed request is a module
  using description file: /tmp/mapped-types-bug/node_modules/@nestjs/mapped-types/package.json (relative path: ./dist)
    resolve as module
      /tmp/mapped-types-bug/node_modules/@nestjs/mapped-types/dist/node_modules doesn't exist or is not a directory
      /tmp/mapped-types-bug/node_modules/@nestjs/mapped-types/node_modules doesn't exist or is not a directory
      /tmp/mapped-types-bug/node_modules/@nestjs/node_modules doesn't exist or is not a directory
      /tmp/mapped-types-bug/node_modules/node_modules doesn't exist or is not a directory
      looking for modules in /tmp/mapped-types-bug/node_modules
        /tmp/mapped-types-bug/node_modules/class-transformer doesn't exist
      /tmp/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
 @ ./node_modules/@nestjs/mapped-types/dist/index.js 19:27-58
 @ ./node_modules/@nestjs/mapped-types/index.js 6:9-26
 @ ./node_modules/@nestjs/swagger/dist/type-helpers/intersection-type.helper.js 4:23-54
 @ ./node_modules/@nestjs/swagger/dist/type-helpers/index.js 13:13-50
 @ ./node_modules/@nestjs/swagger/dist/index.js 18:13-38
 @ ./node_modules/@nestjs/swagger/index.js 6:9-26
 @ ./src/app.controller.ts 13:16-42
 @ ./src/app.module.ts 11:25-52
 @ ./src/main.ts 4:21-44

[kamilmysliwiec]

Add class-transformer/storage to lazyImports https://github.com/hjf/mapped-types-bug/blob/main/webpack.config.js#L2

[adworacz]

I spent a few hours on this particular issue, especially when using fastify as well.

This feels like a potential gap in the existing NestJS serverless documentation. Would a pull request be accepted to update the documentation with the following example?

For those still wrestling with this issue, my webpack.config.js (targeting AWS Lambda) looked like so:

const path = require('path')

// Documentation:
// https://docs.nestjs.com/faq/serverless#serverless
// https://github.com/nestjs/swagger/issues/1334#issuecomment-836488125

// Tell webpack to ignore specific imports that aren't
// used by our Lambda but imported by NestJS (can cause packing errors).
const lazyImports = [
  '@nestjs/microservices/microservices-module',
  '@nestjs/websockets/socket-module',
  '@nestjs/platform-express',
  'swagger-ui-express',
  'class-transformer/storage' // https://github.com/nestjs/mapped-types/issues/486#issuecomment-932715880
]

module.exports = (options, webpack) => ({
  ...options,
  mode: 'production',
  target: 'node14',
  entry: {
    index: './lib/lambda.js',
  },
  output: {
    filename: '[name].js',
    libraryTarget: 'umd',
    path: path.join(process.cwd(), 'build/dist'),
  },
  externals: {
    'aws-sdk': 'aws-sdk',
  },
  plugins: [
    ...options.plugins,
    new webpack.IgnorePlugin({
      checkResource(resource) {
        if (lazyImports.includes(resource)) {
          try {
            require.resolve(resource)
          } catch (err) {
            return true
          }
        }
        return false
      },
    }),
  ],
})