An accessor cannot be declared in an ambient context. #3513

ghiscoding · 2019-11-30T20:18:49Z

Regression

Potential Commit/PR that introduced the regression**

I don't know what introduced this issue, the only thing I found is this Stack Overflow question which says this

so presumably sequelize was compiled with typescript 3.7 and emits definition files that previous versions don't understand. So you'll need to upgrade to typescript 3.7 or use an earlier version of sequelize.

But I'm already using TypeScript version 3.7.2, so I'm not sure where this error comes from and how to fix it.

Describe the regression

I get a bunch of TypeScript lint errors after updating to latest NestJS 6.10.4 (from 6.10.1). I tried going back to ~6.10.1 but I still get the error. I tried upgrading my NodeJS version 10 to 12 but still have the same issue. I also tried using TypeScript version 3.6.3 instead of 3.7.2 but still the issue persist.

I found this bugfix in another library, which removes the get prefix in *.d.ts files, the change is that lib is the following

-  get size(): Size;
+  size: Size;

If I click and follow the link on the first @nestjs/common/http/http.service.d.ts:13:9 error, I do see the get in that d.ts file

export declare class HttpService {
   //...
   get axiosRef(): AxiosInstance;
}

So it seems that the d.ts Type files are not compiled properly? If I manually remove the get from axiosRef(): AxiosInstance;, I get 1 less error. So that seems to be the issue.

export declare class HttpService {
   //...
-   get axiosRef(): AxiosInstance;
+   axiosRef(): AxiosInstance;
}

After manually editing every d.ts file causing errors and removing their get/set I'm back to working again, so that seems to be the issue.

Input Code

Expected behavior/code

Environment


Nest version: 6.10.1 -> 6.10.4

For Tooling issues:
- Node version: 12.13.1
- TypeScript version: 3.7.2
- Platform:  Windows

Others:

The errors I get are the following

node_modules/@nestjs/common/http/http.service.d.ts:13:9 - error TS1086: An accessor cannot be declared in an ambient context.
13     get axiosRef(): AxiosInstance;
           ~~~~~~~~

node_modules/@nestjs/core/helpers/http-adapter-host.d.ts:21:9 - error TS1086: An accessor cannot be declared in an ambient context.
21     set httpAdapter(httpAdapter: T);
           ~~~~~~~~~~~

node_modules/@nestjs/core/helpers/http-adapter-host.d.ts:28:9 - error TS1086: An accessor cannot be declared in an ambient context.
28     get httpAdapter(): T;
           ~~~~~~~~~~~

node_modules/@nestjs/core/injector/container.d.ts:16:9 - error TS1086: An accessor cannot be declared in an ambient context.
16     get applicationConfig(): ApplicationConfig | undefined;
           ~~~~~~~~~~~~~~~~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:32:9 - error TS1086: An accessor cannot be declared in an ambient context.
32     get id(): string;
           ~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:33:9 - error TS1086: An accessor cannot be declared in an ambient context.
33     set instance(value: T);
           ~~~~~~~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:34:9 - error TS1086: An accessor cannot be declared in an ambient context.
34     get instance(): T;
           ~~~~~~~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:35:9 - error TS1086: An accessor cannot be declared in an ambient context.
35     get isNotMetatype(): boolean;
           ~~~~~~~~~~~~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:36:9 - error TS1086: An accessor cannot be declared in an ambient context.
36     get isTransient(): boolean;
           ~~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:20:9 - error TS1086: An accessor cannot be declared in an ambient context.
20     get id(): string;
           ~~

node_modules/@nestjs/core/injector/module.d.ts:21:9 - error TS1086: An accessor cannot be declared in an ambient context.
21     get scope(): Type[];
           ~~~~~

node_modules/@nestjs/core/injector/module.d.ts:22:9 - error TS1086: An accessor cannot be declared in an ambient context.
22     get providers(): Map>;
           ~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:23:9 - error TS1086: An accessor cannot be declared in an ambient context.
23     get imports(): Set;
           ~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:27:9 - error TS1086: An accessor cannot be declared in an ambient context.
27     get relatedModules(): Set;
           ~~~~~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:31:9 - error TS1086: An accessor cannot be declared in an ambient context.
31     get components(): Map>;
           ~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:35:9 - error TS1086: An accessor cannot be declared in an ambient context.
35     get routes(): Map>;
           ~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:36:9 - error TS1086: An accessor cannot be declared in an ambient context.
36     get injectables(): Map>;
           ~~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:37:9 - error TS1086: An accessor cannot be declared in an ambient context.
37     get controllers(): Map>;
           ~~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:38:9 - error TS1086: An accessor cannot be declared in an ambient context.
38     get exports(): Set;
           ~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:39:9 - error TS1086: An accessor cannot be declared in an ambient context.
39     get instance(): NestModule;
           ~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:40:9 - error TS1086: An accessor cannot be declared in an ambient context.
40     get metatype(): Type;
           ~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:41:9 - error TS1086: An accessor cannot be declared in an ambient context.
41     get distance(): number;
           ~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:42:9 - error TS1086: An accessor cannot be declared in an ambient context.
42     set distance(value: number);

The text was updated successfully, but these errors were encountered:

ghiscoding · 2019-11-30T20:19:20Z

Also if it helps, here is my tsconfig.json file

{
  "compilerOptions": {
    "module": "commonjs",
    "declaration": true,
    "removeComments": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "esnext",
    "sourceMap": true,
    "outDir": "./dist",
    "baseUrl": "./",
    "incremental": true
  },
  "exclude": [
    "node_modules",
    "dist"
  ]
}

kamilmysliwiec · 2019-12-01T12:11:55Z

Please, provide a minimal repository which reproduces your issue.

ghiscoding · 2019-12-01T18:12:37Z

I tried replicating the issue on my other desktop and it was all working, however I had to install NestJS CLI because it was never installed on that computer. That made me think to update the CLI on the computer I had issue with... and after updating to latest NestJS CLI, the error is gone.

Since I can't replicate after updating NestJS CLI, I'll close the issue
Thanks

kotuadam · 2019-12-01T23:14:51Z

I am having the same problem... Fresh install and updating cli does not solve it. Operating system is Mac OS

ghiscoding · 2019-12-02T01:26:02Z

@kotuadam
There's couple things you can try, the first one is to delete the entire node_modules and also the yarn/npm lock files, then re-install everything. The other options would be to see which TypeScript version you're using, I'm on 3.7.2 which is the latest.

syukirah · 2019-12-02T07:11:27Z

I'm also facing the same problem. Its working in my local but failed when i deploy to server (openshift)

Figments · 2019-12-02T07:16:04Z

Same issue here.

whitebyte · 2019-12-02T08:23:15Z

This issue is relevant, please reopen. I just encountered the same error while trying to update from 6.7.2 to 6.10.4. Managed to resolve it somehow after wiping node_modules and doing npm upgrade, but no idea how to reproduce it.

kamilmysliwiec · 2019-12-02T08:50:55Z

It sounds like a breaking change introduced in TypeScript microsoft/TypeScript#33939

jeffminsungkim · 2019-12-02T09:16:23Z

@nestjs/core v6.10.4

@nestjs/core v6.10.2

Currently using Typescript v3.5.1

Figments · 2019-12-02T09:18:02Z

Switching entirely to Yarn seems to have fixed the issue for me, though the reason why NPM seemed to be the cause of my specific issues is beyond me.

franzos · 2019-12-02T09:35:41Z

I've been able to resolve this, by manually upgrading typescript.

package.json: "typescript": "3.4.3" to "typescript": "3.7.2"

finally, cleared out, and re-installed everything:

rm -r node_modules; rm package-lock.json
npm install

kamilmysliwiec · 2019-12-02T09:43:33Z

I've published v6.10.5 release with a downgraded TypeScript to 3.6.4 version. If you are facing this issue, please, update to the latest version of @nestjs. Hopefully, TypeScript team will solve this shortly

kotuadam · 2019-12-02T12:45:21Z

latest push fixed everything for me

ghost · 2019-12-10T21:04:13Z

Facing this issue when adding @nestjs/ng-universal to Angular 8 project.
Have tried with latest Nestjs version 6.10.9 and with Typescript 3.5.3. I am not able to upgrade typescript to newer version, Angular CLI does not support > 3.6.0

Application starts up normal but errors persists.

`10% building 3/3 modules 0 activenode_modules/@nestjs/common/http/http.service.d.ts:13:9 - error TS1086: An accessor cannot be declared in an ambient context.

13 get axiosRef(): AxiosInstance;
~~~~~~~~

node_modules/@nestjs/core/helpers/http-adapter-host.d.ts:21:9 - error TS1086: An accessor cannot be declared in an ambient context.

21 set httpAdapter(httpAdapter: T);
~~~~~~~~~~~

node_modules/@nestjs/core/helpers/http-adapter-host.d.ts:28:9 - error TS1086: An accessor cannot be declared in an ambient context.

28 get httpAdapter(): T;
~~~~~~~~~~~

node_modules/@nestjs/core/injector/container.d.ts:18:9 - error TS1086: An accessor cannot be declared in an ambient context.

18 get applicationConfig(): ApplicationConfig | undefined;
~~~~~~~~~~~~~~~~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:32:9 - error TS1086: An accessor cannot be declared in an ambient context.

32 get id(): string;
~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:33:9 - error TS1086: An accessor cannot be declared in an ambient context.

33 set instance(value: T);
~~~~~~~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:34:9 - error TS1086: An accessor cannot be declared in an ambient context.

34 get instance(): T;
~~~~~~~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:35:9 - error TS1086: An accessor cannot be declared in an ambient context.

35 get isNotMetatype(): boolean;
~~~~~~~~~~~~~

node_modules/@nestjs/core/injector/instance-wrapper.d.ts:36:9 - error TS1086: An accessor cannot be declared in an ambient context.

36 get isTransient(): boolean;
~~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:20:9 - error TS1086: An accessor cannot be declared in an ambient context.

20 get id(): string;
~~

node_modules/@nestjs/core/injector/module.d.ts:21:9 - error TS1086: An accessor cannot be declared in an ambient context.

21 get scope(): Type[];
~~~~~

node_modules/@nestjs/core/injector/module.d.ts:22:9 - error TS1086: An accessor cannot be declared in an ambient context.

22 get providers(): Map<any, InstanceWrapper>;
~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:23:9 - error TS1086: An accessor cannot be declared in an ambient context.

23 get imports(): Set;
~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:27:9 - error TS1086: An accessor cannot be declared in an ambient context.

27 get relatedModules(): Set;
~~~~~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:31:9 - error TS1086: An accessor cannot be declared in an ambient context.

31 get components(): Map<string, InstanceWrapper>;
~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:35:9 - error TS1086: An accessor cannot be declared in an ambient context.

35 get routes(): Map<string, InstanceWrapper>;
~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:36:9 - error TS1086: An accessor cannot be declared in an ambient context.

36 get injectables(): Map<string, InstanceWrapper>;
~~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:37:9 - error TS1086: An accessor cannot be declared in an ambient context.

37 get controllers(): Map<string, InstanceWrapper>;
~~~~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:38:9 - error TS1086: An accessor cannot be declared in an ambient context.

38 get exports(): Set<string | symbol>;
~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:39:9 - error TS1086: An accessor cannot be declared in an ambient context.

39 get instance(): NestModule;
~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:40:9 - error TS1086: An accessor cannot be declared in an ambient context.

40 get metatype(): Type;
~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:41:9 - error TS1086: An accessor cannot be declared in an ambient context.

41 get distance(): number;
~~~~~~~~

node_modules/@nestjs/core/injector/module.d.ts:42:9 - error TS1086: An accessor cannot be declared in an ambient context.

42 set distance(value: number);
~~~~~~~~

[21:58:20] Found 23 errors. Watching for file changes.`

kamilmysliwiec · 2019-12-10T21:05:27Z

Lets track this here microsoft/TypeScript#33939

ghiscoding added needs triage This issue has not been looked into type: bug 😭 labels Nov 30, 2019

kamilmysliwiec added needs clarification and removed needs triage This issue has not been looked into type: bug 😭 labels Dec 1, 2019

ghiscoding closed this as completed Dec 1, 2019

kamilmysliwiec reopened this Dec 2, 2019

kamilmysliwiec closed this as completed Dec 3, 2019

kamilmysliwiec mentioned this issue Dec 6, 2019

TS 3.7: --declaration output for getter only property now is a getter instead of readonly microsoft/TypeScript#33939

Closed

nestjs locked as too heated and limited conversation to collaborators Dec 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

An accessor cannot be declared in an ambient context. #3513

An accessor cannot be declared in an ambient context. #3513

ghiscoding commented Nov 30, 2019 •

edited

Loading

ghiscoding commented Nov 30, 2019 •

edited

Loading

kamilmysliwiec commented Dec 1, 2019

ghiscoding commented Dec 1, 2019

kotuadam commented Dec 1, 2019

ghiscoding commented Dec 2, 2019

syukirah commented Dec 2, 2019

Figments commented Dec 2, 2019

whitebyte commented Dec 2, 2019

kamilmysliwiec commented Dec 2, 2019

jeffminsungkim commented Dec 2, 2019

Figments commented Dec 2, 2019

franzos commented Dec 2, 2019

kamilmysliwiec commented Dec 2, 2019

kotuadam commented Dec 2, 2019

ghost commented Dec 10, 2019

kamilmysliwiec commented Dec 10, 2019

An accessor cannot be declared in an ambient context. #3513

An accessor cannot be declared in an ambient context. #3513

Comments

ghiscoding commented Nov 30, 2019 • edited Loading

Regression

Potential Commit/PR that introduced the regression**

Describe the regression

Input Code

Expected behavior/code

Environment

ghiscoding commented Nov 30, 2019 • edited Loading

kamilmysliwiec commented Dec 1, 2019

ghiscoding commented Dec 1, 2019

kotuadam commented Dec 1, 2019

ghiscoding commented Dec 2, 2019

syukirah commented Dec 2, 2019

Figments commented Dec 2, 2019

whitebyte commented Dec 2, 2019

kamilmysliwiec commented Dec 2, 2019

jeffminsungkim commented Dec 2, 2019

Figments commented Dec 2, 2019

franzos commented Dec 2, 2019

kamilmysliwiec commented Dec 2, 2019

kotuadam commented Dec 2, 2019

ghost commented Dec 10, 2019

kamilmysliwiec commented Dec 10, 2019

ghiscoding commented Nov 30, 2019 •

edited

Loading

ghiscoding commented Nov 30, 2019 •

edited

Loading