Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find name 'URL' - type url is not imported in responseCheck (health-indicator/http/http.health.ts) #1623

Closed
2 of 4 tasks
rudemex opened this issue Jan 14, 2022 · 1 comment

Comments

@rudemex
Copy link

rudemex commented Jan 14, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

I am building a centralized healtcheks module, but the URL data type is not defined and it breaks the build with pika.

image

Minimum reproduction code

  1. git clone https://github.com/tresdoce/nestjs-health.git
  2. git checkout feat/update
  3. npm install
  4. npm run build
  5. see the error
...
[3/6] Running @pika/plugin-ts-standard-pkg...
node_modules/@nestjs/terminus/dist/health-indicator/http/http.health.d.ts(51,40): error TS2304: Cannot find name 'URL'.
...

Steps to reproduce

  1. git clone https://github.com/tresdoce/nestjs-health.git
  2. git checkout feat/update
  3. npm install
  4. npm run build
  5. see the error
...
[3/6] Running @pika/plugin-ts-standard-pkg...
node_modules/@nestjs/terminus/dist/health-indicator/http/http.health.d.ts(51,40): error TS2304: Cannot find name 'URL'.
...

Expected behavior

add import { URL } from 'url'; in this file https://github.com/nestjs/terminus/blob/master/lib/health-indicator/http/http.health.ts

Package version

8.0.3

NestJS version

8.2.5

Node.js version

14.15.4

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@rudemex rudemex changed the title responseCheck "URL" type is undefined Cannot find name 'URL' - type url is not imported in responseCheck (health-indicator/http/http.health.ts) Jan 15, 2022
@BrunnerLivio
Copy link
Member

Fixed with 8.0.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants