-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: health indicator for Prisma ORM #2250
Conversation
Hey @ThallesP appreciate this PR. The baseline looks good so far. Would it be possible to fix the CI issues as well as adding an e2e test? For the e2e test you can inspire yourself from the mikro orm test |
Yes, no problem, I'm still finishing it (I should've marked this PR as a draft). |
Ready for review, added tests too @BrunnerLivio |
"@nestjs/common": "9.3.2", | ||
"@nestjs/core": "9.3.2", | ||
"@nestjs/platform-express": "9.3.2", | ||
"@nestjs/terminus": "9.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be updated to a newer version with the Prisma changes or else it will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the prisms sample should be updated to a newer version with these PR changes.
@BrunnerLivio prisma only supports v14 and above, that's why the ci/cd failed, might need to bump the node version. |
I merged this PR in the |
@BrunnerLivio technically we don't depend on but the ci/cd would be broken as it tests against node v12. |
@ThallesP I am aware it technically works but I can't drop the Node v12 Pipeline just for Prisma. It's for sure technically possible to not install Prisma or run the Prisma-related tests during the v12 Pipeline but I'd prefer not to jump through these hoops. |
* feat: health indicator for Prisma ORM (#2250) * chore: drop support for Node v12 BREAKING CHANGE: drop support for Node v12 * chore: fix prisma sample * chore: add prisma client as optional peer dependency * refactor(prisma): rename PrismaORM to PrismaHealthIndicator * chore(): release v10.0.0-beta.0 * chore: fix format * chore: add node v18 and v20 * chore: drop support for node v14 BREAKING CHANGE: drop support for node v14 * feat: upgrade to nest v10 * feat(deps): upgrade TypeScript to v5 * chore: update dependencies * feat(disk): prettify type information * chore(): release v10.0.0-beta.1 * Revert "feat(disk): prettify type information" This reverts commit e0b13aa. * chore: use --legacy-peer-deps in ci Revert once mikro-orm/nestjs#122 is resolved * chore: remove prisma timeout * chore: add debian openssl for prisma --------- Co-authored-by: Thalles Passos <contato@thalles.me>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1510
What is the new behavior?
Add supports for the Prisma ORM
Does this PR introduce a breaking change?
Other information
Currently it only supports SQL based databases, I'm still working on the MongoDB integration.