Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responseCheck throwing internal error (#2395) #2452

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

chamsou123
Copy link
Contributor

@chamsou123 chamsou123 commented Nov 27, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

When employing the HttpHealthIndicator.responseCheck health indicator, if there's a network error detected in the checked URL, the system fails to handle it appropriately, leading to the health check route throwing a 500 internal error.

Issue Number: #2395

What is the new behavior?

The system now appropriately handles network errors, ensuring that the health check route no longer results in a 500 internal error.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@BrunnerLivio BrunnerLivio merged commit 5df9aff into nestjs:master Jan 26, 2024
@BrunnerLivio
Copy link
Member

Appreciate it @chamsou123 , will release right away!

@BrunnerLivio
Copy link
Member

Released with v10.2.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants