Compatibility with middlewares

[mhavelant]

I'm submitting a...

[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Add a middleware via app.use() [with or without the FastifyAdapter], e.g:

app.use((req, res, next) => { logger.info("This is a request."); next(); });
Then call /health/readiness (or any terminus routes). No message is logged for terminus routes (but it is for other custom routes).

Note: I also have morgan set up for more convenient request logging, it doesn't work either. Version:

"morgan": "^1.9.1",

Expected behavior

The above middleware should log "This is a request" to the console on every request to a terminus route.

Minimal reproduction of the problem with instructions

See "Current behavior".

What is the motivation / use case for changing the behavior?

Using middlewares is supported by nest, and logging requests is useful for debugging, bug tracing, etc., so it would be a great addition/fix.

Environment

Nest version: 5.5.0
Nest terminus version: 5.5.2

 
For Tooling issues:
- Node version: v10.15.0  
- Platform: Linux/Docker 

Others:

[llienard]

Hi,

I'm facing this issue too. I would like to add some authorization requirements to access the healthchecker url.

Is there any update about this ?

[oleg-yudovich]

Hi,

We must to be able to use our middlewares on health route.

Any updates regarding the fix?

[BrunnerLivio]

Resolved in 7.0.0 🎉

Terminus v7 now uses the native NestJS route handler, therefore you can use the middleware as you are used to with NestJS!