Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'make test' errors on tests not included in release tarball #3712

Closed
hlein opened this issue Oct 31, 2020 · 2 comments
Closed

'make test' errors on tests not included in release tarball #3712

hlein opened this issue Oct 31, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@hlein
Copy link
Contributor

hlein commented Oct 31, 2020

Bug and expected behavior

  • make test produces some errors because Makefile.in's default test target includes test-private-lib and test-fnetfilter; the release tarball has no such subdirectories under test/.
  • Those are present in the git repo, but not in the release tarballs; Makefile.in's DISTFILES_TEST= enumerates test/ dirs to package, excluding those two.
  • The right/expected behavior would be some combination of 1) including more test/ subdirs in release tarballs, 2) pruning the list of test-* targets included in the default test: target in Makefile.in, 3) checking for the presence of, and gracefully handling the lack of, individual test/ subdirs.

Reproduce
Steps to reproduce the behavior:

  1. unpack tarball such as firejail-0.9.64.tar.xz
  2. configure and compile
  3. run make test
  4. Errors such as:
cd test/private-lib; ./private-lib.sh | grep TESTING
...
/bin/sh: line 0: cd: test/private-lib: No such file or directory
/bin/sh: ./private-lib.sh: No such file or directory
...
cd test/fnetfilter; ./fnetfilter.sh | grep TESTING
...
/bin/sh: line 0: cd: test/fnetfilter: No such file or directory
/bin/sh: ./fnetfilter.sh: No such file or directory
...
make: *** [Makefile:232: test-private-lib] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:265: test-fnetfilter] Error 1

Environment

  • Gentoo Linux
  • firejail-0.9.64
@netblue30 netblue30 added the bug Something isn't working label Nov 1, 2020
@netblue30 netblue30 added this to the 0.9.65 milestone Nov 1, 2020
@netblue30
Copy link
Owner

Thanks for the bug, should be fixed now.

@hlein
Copy link
Contributor Author

hlein commented Nov 1, 2020

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants