You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
make test produces some errors because Makefile.in's default test target includes test-private-lib and test-fnetfilter; the release tarball has no such subdirectories under test/.
Those are present in the git repo, but not in the release tarballs; Makefile.in's DISTFILES_TEST= enumerates test/ dirs to package, excluding those two.
The right/expected behavior would be some combination of 1) including more test/ subdirs in release tarballs, 2) pruning the list of test-* targets included in the default test: target in Makefile.in, 3) checking for the presence of, and gracefully handling the lack of, individual test/ subdirs.
Reproduce
Steps to reproduce the behavior:
unpack tarball such as firejail-0.9.64.tar.xz
configure and compile
run make test
Errors such as:
cd test/private-lib; ./private-lib.sh | grep TESTING
...
/bin/sh: line 0: cd: test/private-lib: No such file or directory
/bin/sh: ./private-lib.sh: No such file or directory
...
cd test/fnetfilter; ./fnetfilter.sh | grep TESTING
...
/bin/sh: line 0: cd: test/fnetfilter: No such file or directory
/bin/sh: ./fnetfilter.sh: No such file or directory
...
make: *** [Makefile:232: test-private-lib] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:265: test-fnetfilter] Error 1
Environment
Gentoo Linux
firejail-0.9.64
The text was updated successfully, but these errors were encountered:
Bug and expected behavior
make test
produces some errors becauseMakefile.in
's defaulttest
target includestest-private-lib
andtest-fnetfilter
; the release tarball has no such subdirectories undertest/
.Makefile.in
'sDISTFILES_TEST=
enumeratestest/
dirs to package, excluding those two.test/
subdirs in release tarballs, 2) pruning the list oftest-*
targets included in the defaulttest:
target inMakefile.in
, 3) checking for the presence of, and gracefully handling the lack of, individualtest/
subdirs.Reproduce
Steps to reproduce the behavior:
firejail-0.9.64.tar.xz
make test
Environment
The text was updated successfully, but these errors were encountered: