Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework quiet, debug and normal console output #4275

Open
rusty-snake opened this issue May 13, 2021 · 2 comments
Open

Rework quiet, debug and normal console output #4275

rusty-snake opened this issue May 13, 2021 · 2 comments
Labels
enhancement New feature request

Comments

@rusty-snake
Copy link
Collaborator

rusty-snake commented May 13, 2021

We have multiple issues about how we print something to the console, which all go to the same code. Therefore I make this meta-issue.

There are some more which aren't handled here like:


Good to read:

IMHO we should only print warnings and errors to stderr by default and be quiet for everything else. The current quiet would be then a hard-queit if a program really need full ownership of stderr. In addition a --info/--verbose/--debug=1/--debug=little/whatever will show the current default output.

All the warnings/errors should make clear that they are printed by firejail (e.g. firejail:Error:).

For the debug output it would be enough to print something like

--- end of firejail output ---
@rusty-snake rusty-snake added the enhancement New feature request label May 13, 2021
@glitsj16
Copy link
Collaborator

All the warnings/errors should make clear that they are printed by firejail (e.g. firejail:Error:).

This reminds me of #3325, which never really got of the ground. @topimiettinen mentioned a possibility to improve errExit() and use it everywhere with a prefix. IMO that would solve this part of the issue. Just adding it here for future reference.

@slowpeek
Copy link
Contributor

slowpeek commented Jun 3, 2021

I'm not sure is there a single reason to use stdout in firejail. It is a wrapper, hence it should not touch neither stdin nor stdout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

No branches or pull requests

3 participants