Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases fail for interface type: other-wireless #1460

Closed
etherwrangler opened this issue Jul 16, 2023 · 4 comments
Closed

Test cases fail for interface type: other-wireless #1460

etherwrangler opened this issue Jul 16, 2023 · 4 comments
Assignees

Comments

@etherwrangler
Copy link
Contributor

In the NetBox web ui there is an interface type of Other (Wireless) available. If a yaml file is created with the snippet below, the pre-commit script fails because schema/components.json is missing this definition.

  - name: wlan2
    type: other-wireless

I made sure this is the expected type by exporting a device via the web ui.

@danner26
Copy link
Member

I just double checked and you are correct, the type other-wireless is the correct one. If you'd like, you can create a PR to add this interface type. If you'd rather I can do so as well

Just let me know. Thanks for catching this! As a side note, we try to avoid using other in these definition files as much as possible.

What interface type are you trying to add that does not already exist?

@danner26 danner26 changed the title Pre-Commit checks fail if interface type of "other-wireless" is used Test cases fail for interface type other-wireless Jul 16, 2023
@danner26 danner26 changed the title Test cases fail for interface type other-wireless Test cases fail for interface type: other-wireless Jul 16, 2023
@etherwrangler
Copy link
Contributor Author

I'm working on adding some Meraki wireless devices.
https://documentation.meraki.com/MR/MR_Overview_and_Specifications/MR46_Datasheet

A dedicated third radio provides real-time WIDS/WIPS, with automated RF optimization.

Since the 3rd radio isn't used for data, Other (Wireless) seemed to fit best. If you'd prefer that one have another type I can go ahead an update those before I submit the PR that will be coming for that.

I'll get a PR submitted to add other-wireless in a bit.

@danner26
Copy link
Member

Sounds good about other-wireless

Could you send me a link to the datasheet for the device with this radio?

@etherwrangler
Copy link
Contributor Author

etherwrangler commented Jul 16, 2023

https://documentation.meraki.com/MR/MR_Overview_and_Specifications/MR46_Datasheet

But to keep from cluttering this, if you'd rather we can discuss when I submit that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants