Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable image attachments for device types #10414

Closed
jcralbino opened this issue Sep 20, 2022 · 8 comments
Closed

Enable image attachments for device types #10414

jcralbino opened this issue Sep 20, 2022 · 8 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@jcralbino
Copy link

jcralbino commented Sep 20, 2022

NetBox version

v3.3.4

Feature type

Change to existing functionality

Proposed functionality

Currently in the device type, we are allowing the introduction of two types of images:

  • rear image. Used for the rack rendering
  • front image. Used for the rack rendering

[ ]The Device Type "Front" and "Rear" images have a very limited scope as we want those images to be super high-quality or detailed (as they are used in the Rack Elevation and get shrunk down fairly small anyway, plus you want them to be perfectly straight-on for the Rack Elevation view).

  • I propose that within the device type we also introduce a generic image field, that is then copied to every new device created using this template.

Use case

Image inside the device are used to provide additional relevant information for each device, improving the documentation on site and the utilisation of this information with non technical people

  • a generic image of a device can be helpful to describe various aspects about the equipment to them, and is much better than "no images at all."

Database changes

  • adding a new field in the device-type data model referring to the image. As used in the device itself.

External dependencies

No response

@jcralbino jcralbino added the type: feature Introduction of new functionality to the application label Sep 20, 2022
@jeremystretch
Copy link
Member

I'm sorry but I don't follow exactly what it is you're proposing, or why. Please rewrite your proposal above to clearly convey the proposed change and cited use case.

@jeremystretch jeremystretch added the status: revisions needed This issue requires additional information to be actionable label Sep 26, 2022
@ZPrimed
Copy link

ZPrimed commented Sep 30, 2022

I think I understand what the OP is asking for here - they're asking for a generic "image" field on a Device Type that would automatically be inherited by (copied into) all Device instances that are spawned from that Device Type. Device already allows Image uploads which is great for documenting devices in situ, but in the real world, we don't always have a photo of the specific device we're talking about.

This sort of thing is incredibly useful when you're dealing with "non-technical remote hands" (i.e. end-users) - a generic image of a device can be helpful to describe various aspects about the equipment to them, and is much better than "no images at all."

The Device Type "Front" and "Rear" images aren't even necessarily the best for this kind of "generic picture," since you don't really want those images to be super high-quality or detailed (as they are used in the Rack Elevation and get shrunk down fairly small anyway, plus you want them to be perfectly straight-on for the Rack Elevation view).

Sure, you can always search the web for a generic image, but a lot of person-hours can be saved in aggregate if someone takes a few minutes to put a quality generic image into the DCIM when creating the Device Type. Needing to duplicate / re-attach that image to every Device instance is a pain, and it would be nice to have some way to provide a generic and have it apply to everything spawned from the Type.

I have no clue how feasible this is, but I definitely think it would be helpful.

@jeremystretch
Copy link
Member

We could add support for generic image attachments to the DeviceType model, but I don't see any reason for anything more complex than that. At any rate, let's wait for @jcralbino to clarify his intent.

@jcralbino
Copy link
Author

I have changed slightly the text in the initial request but the goal is aligned with what was explained by @ZPrimed

@jeremystretch
Copy link
Member

I propose that within the device type we also introduce a generic image field, that is then copied to every new device created using this template.

There is no need to copy this field's value to instantiated devices, because each device already has a relationship to the device type: What is true for one instance is true for all.

As I mentioned, we could introduce support for attaching images to device types, which seems like it would satisfy your use case. If it does not, please elaborate on why.

@jcralbino
Copy link
Author

As long as the images associated with the device type are also seen under the device view also that would work

@jeremystretch jeremystretch changed the title Add image field to Device Type Enable image attachments for device types Nov 2, 2022
@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation and removed status: revisions needed This issue requires additional information to be actionable labels Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Jan 2, 2023
@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Apr 6, 2023
@jeremystretch jeremystretch self-assigned this Apr 10, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Apr 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants