Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new VM Cluster does not save when site is left blank #10436

Closed
danie-dejager opened this issue Sep 22, 2022 · 4 comments
Closed

Adding new VM Cluster does not save when site is left blank #10436

danie-dejager opened this issue Sep 22, 2022 · 4 comments

Comments

@danie-dejager
Copy link

danie-dejager commented Sep 22, 2022

NetBox version

v3.3.4

Python version

3.8

Steps to Reproduce

  1. Create a new Region.
  2. Create a Site Group
  3. Create a new Virtualization Cluster
  4. Edit Cluster
  5. Assign Region and Site group to Cluster
  6. Click Save
    image
  7. Go back to edit the Cluster.
  8. The Region and site is not saved as seen in item 6.
    image

When a new site was created and assigned to the Region and Site Group and selected when updating the Cluster, then all three values will be saved.
image

Expected Behavior

If all three values are required to save a cluster's Site then there should not be a successful green confirmation that the items were saved.

Observed Behavior

The Update is not saved but when clicked Netbox stated that the change was saved. Going back to the Cluster does not show the added Site or Site Group.

@danie-dejager danie-dejager added the type: bug A confirmed report of unexpected behavior in the application label Sep 22, 2022
@arthanson arthanson added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Sep 22, 2022
@arthanson arthanson self-assigned this Sep 22, 2022
@arthanson arthanson removed the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Sep 22, 2022
@arthanson
Copy link
Collaborator

This is sort of interesting as the Region and Site group are just filters for the Site, not actually saved - only the Site is saved. If the site is saved then the Region and Site group come from the saved site when edited.

@danie-dejager
Copy link
Author

danie-dejager commented Sep 23, 2022

If it is an EC2 instance should I add them in Virtualization or add them as you'd add physical devices? I only wanted to assign a region to the VM cluster as it did not have a site.

@kkthxbye-code
Copy link
Contributor

I really don't think there is anything to do here specifically. It should be covered by #10054. It's also the intended functionality currently, so not really a bug imo.

@jeremystretch
Copy link
Member

I really don't think there is anything to do here specifically. It should be covered by #10054. It's also the intended functionality currently, so not really a bug imo.

Agreed. The site group and region fields exist solely to aid in the selection of a site for the cluster; there is no direct relationship from a cluster to these objects. Admittedly this can be a bit confusing, but that's why #10054 has been raised.

I only wanted to assign a region to the VM cluster as it did not have a site.

It's not possible to assign a cluster to a region, however the assignment of a site is optional. For e.g. an AWS cluster you can simply not assign a site.

@jeremystretch jeremystretch closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2022
@jeremystretch jeremystretch removed the type: bug A confirmed report of unexpected behavior in the application label Sep 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants