Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong SVG visualization with multiple path in Circuits Terminations #11184

Closed
renatoalmeidaoliveira opened this issue Dec 15, 2022 · 3 comments
Closed
Assignees
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@renatoalmeidaoliveira
Copy link
Contributor

renatoalmeidaoliveira commented Dec 15, 2022

NetBox version

v3.3.10

Python version

3.8

Steps to Reproduce

  1. Create a Circuit (Multi-Root)
  2. Create a Circuit (Multi-100)
  3. Create a Circuit (Multi-200)
  4. Create on each Circuit a termination in the same site, and connect Multi-100 and Multi-200 to Multi-Root
  5. Connect the other Circuit termination to some device interface

Expected Behavior

When you render the connection trace in the interface connected to the Multi-Root all other circuits and device interfaces are show in the svg

Observed Behavior

Trace from the interface connected to the Multi-Root Circuit:

image

Trace from the interface connected to the Multi-100 Circuit:

image

Trace from the interface connected to the Multi-200 Circuit:

image

@renatoalmeidaoliveira renatoalmeidaoliveira added the type: bug A confirmed report of unexpected behavior in the application label Dec 15, 2022
@renatoalmeidaoliveira renatoalmeidaoliveira changed the title Wrong SVG visualization with multiple path in circuits Wrong SVG visualization with multiple path in Circuits Terminations Dec 15, 2022
@jeremystretch
Copy link
Member

  1. Create on each Circuit a termination in the same site, and connect Multi-100 and Multi-200 to Multi-Root

Please expand on this, as it's not clear exactly what connections are to be made.

@jeremystretch jeremystretch added the status: revisions needed This issue requires additional information to be actionable label Dec 15, 2022
@renatoalmeidaoliveira
Copy link
Contributor Author

@jeremystretch
1 - For all Circuits create Termination A on the same site.
2 - In the Circuit Multi-Root go in Termination A and click in connect and choose Circuit Termination
3 - In the Side B, add the Side B termination of the other Circuits (Multi-100 and Multi-200)

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: revisions needed This issue requires additional information to be actionable labels Dec 16, 2022
@jeremystretch jeremystretch self-assigned this Dec 16, 2022
@jeremystretch
Copy link
Member

When you render the connection trace in the interface connected to the Multi-Root all other circuits and device interfaces are show in the svg

We can only render cable paths up to the point where there's a divergent split, which in this case is the two far-end circuit terminations. The correct behavior should be to convey that the path splits and give the user the option of choosing one branch to follow. Here's what I've implemented:

Screenshot 2022-12-16 at 16-27-29 Cable Trace for Interface GigabitEthernet0_1_2 NetBox

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants