Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSVDataField and CSVFileField are unused and should be removed #11955

Closed
kkthxbye-code opened this issue Mar 10, 2023 · 0 comments · Fixed by #11966
Closed

CSVDataField and CSVFileField are unused and should be removed #11955

kkthxbye-code opened this issue Mar 10, 2023 · 0 comments · Fixed by #11966
Assignees
@arthanson
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.5

Comments

@kkthxbye-code
Copy link
Contributor

Proposed Changes

It appears that CSVDataField and CSVFileField are not used anymore. Should probably be removed.

Justification

Unused code should be removed.
@kkthxbye-code kkthxbye-code added the type: housekeeping Changes to the application which do not directly impact the end user label Mar 10, 2023
@arthanson arthanson self-assigned this Mar 13, 2023
@arthanson arthanson mentioned this issue Mar 13, 2023
Merged
@jeremystretch jeremystretch added this to the v3.5 milestone Mar 16, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Mar 16, 2023
@jeremystretch jeremystretch mentioned this issue Apr 27, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.5
Development

Successfully merging a pull request may close this issue.

11955 remove csvdatafield csvfilefield netbox-community/netbox
3 participants
@arthanson @kkthxbye-code @jeremystretch