Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign secrets to virtual machines #1495

Closed
candlerb opened this issue Sep 15, 2017 · 4 comments
Closed

Assign secrets to virtual machines #1495

candlerb opened this issue Sep 15, 2017 · 4 comments

Comments

@candlerb
Copy link
Contributor

Issue type

[X] Feature request
[ ] Bug report
[ ] Documentation

Environment

  • Python version: 3.5.2
  • NetBox version: v2.2-beta1

Description

Currently you can attach secrets to Devices but not Virtual Machines.

Use cases:

  • Storing per-VM administrator/console logins
  • Someone who uses secrets for Devices will probably want to use them for VMs too.
  • Conversely, someone who finds they cannot use secrets for VMs (and hence needs an external solution) will likely use the external solution for Devices too.

Aside: I don't use netbox secrets myself for various reasons. I am entering this ticket so that a decision can be recorded either way.

It might be worth a poll to see who does use this feature; and if it's not widely used, consider removing it.

@jeremystretch jeremystretch changed the title Virtualization: secrets Assign secrets to virtual machines Sep 15, 2017
@darkstar
Copy link

It was made quite clear that NetBox is not intended for that. See #142 (comment) for a comment on secrets for VMs.

I would probably use that feature if it were available, but I don't particularly need it (I have other means to store the secrets for VMs, and I kind of agree with the fact that NetBox is not designed to reach that far into the administrative level of the VMs)

@jeremystretch
Copy link
Member

jeremystretch commented Sep 18, 2017

@darkstar That comment was made before the v2.2 beta introduced support for virtual machines and clusters. v2.2 will definitely have virtual machines; whether or not we want to extend secrets to them and other objects (see #1503) is still open for discussion.

@darkstar
Copy link

@jeremystretch I am aware of that but you later posted that you're still leaning towards "no" on the issue, and for the same reasons (see #142 (comment)). Maybe I should have linked to that comment instead ;-)

The idea of #1503 never crossed my mind... it seems there are quite a few cases where secrets could be useful. If so, it certainly makes sense to also add them to VMs/Clusters

@jeremystretch
Copy link
Member

I'm going to close this issue for now in favor of #1503, which would cover extending secrets to VMs. If #1503 falls through, this issue can be re-opened.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants