Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Microsoft Azure AD to Microsoft Entra ID #15829

Closed
zacho112 opened this issue Apr 24, 2024 · 5 comments · Fixed by #17616
Closed

Rename Microsoft Azure AD to Microsoft Entra ID #15829

zacho112 opened this issue Apr 24, 2024 · 5 comments · Fixed by #17616
Assignees
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@zacho112
Copy link
Contributor

zacho112 commented Apr 24, 2024

Netbox version

v4.0.2

Feature type

Change to existing functionality

Proposed functionality

Microsoft renamed Azure AD to Entra ID

Rename string and filenames in these files.

Most important I'd like to get the wording on the frontpage changed to match the correct and new name, Microsoft Entra ID.
image

Also update the documentation as well

Use case

Makes name match Microsoft's new branding

Database changes

None

External dependencies

None.

I'd gladly create the PR and update the files my self.

@zacho112 zacho112 added status: needs triage This issue is awaiting triage by a maintainer type: documentation A change or addition to the documentation labels Apr 24, 2024
@jeffgdotorg jeffgdotorg added status: revisions needed This issue requires additional information to be actionable and removed status: needs triage This issue is awaiting triage by a maintainer labels Apr 24, 2024
@jeffgdotorg jeffgdotorg removed their assignment Apr 24, 2024
@jeffgdotorg
Copy link
Contributor

jeffgdotorg commented Apr 24, 2024

Thanks for opening this issue. One clarification before we'll be able to talk about a PR:

I'd like to get the wording on the frontpage changed

Is this ask specific to the docs, or is it scoped to the NetBox UI itself? In the latter case, please revise this issue's body to remove it and create a separate enhancement issue.

@zacho112
Copy link
Contributor Author

Most important I'd like the UI to change :) But I think it would be great to have the docs updated as well, which is why I created both in the same issue, but I understand if I need to split it up.

So just to ensure that I'm doing it the right way, I edit this issue to only take care of the actual docs, and create a new issue that handles the string/code changes in the codebase?

@arthanson arthanson added type: feature Introduction of new functionality to the application status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation and removed type: documentation A change or addition to the documentation status: revisions needed This issue requires additional information to be actionable labels May 15, 2024
@arthanson
Copy link
Collaborator

@zacho112 I think we can keep it as a single issue, I changed the format to be a feature request as it requires code changes.

@jeremystretch jeremystretch added the complexity: low Requires minimal effort to implement label May 21, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 20, 2024
@alehaa
Copy link
Contributor

alehaa commented Sep 25, 2024

I can provide a PR for this.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation pending closure Requires immediate attention to avoid being closed for inactivity labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: low Requires minimal effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants