Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search results not showing Virtual Machine primary IP address #1587

Closed
candlerb opened this issue Oct 13, 2017 · 4 comments
Closed

Global search results not showing Virtual Machine primary IP address #1587

candlerb opened this issue Oct 13, 2017 · 4 comments
Labels
type: feature Introduction of new functionality to the application

Comments

@candlerb
Copy link
Contributor

Issue type

[ ] Feature request
[X] Bug report
[ ] Documentation

Environment

  • Python version: 3.5.2
  • NetBox version: 2.2.1

Description

When you do a global search, and you get tables for matching Devices and Virtual Machines, the Devices have an IP address column but the Virtual Machines do not.

Relates to #1496: if you go to the Virtual Machines listing and do a search there the IP address is now shown, but the corresponding update to global search results page was not made.

@darkstar
Copy link

Could you please describe what exactly you are searching for?

If I enter an IP Address (that exists and is attached to a VM) in the global search box, I get 3 tables, Aggregates, Prefixes and IP Addresses. The 3rd table correctly shows the IP Address, and shows the VM as "parent", no matter if it's the primary IP for the VM or not.

@candlerb
Copy link
Contributor Author

candlerb commented Oct 13, 2017

Using the global search box on the home page, I search for a device or VM by name, entering part of its name. For example, let's say I enter "ftp".

I then see devices with "ftp" in their name, and VMs with "ftp" in their name.

In this results page, the table of devices includes primary IP address; however the table of VMs is missing the primary IP address column.

update

Just to be clear, the global search results page is /search/?q=ftp&obj_type=

This is different to going to the virtual machines page and searching there, which is /virtualization/virtual-machines/?q=ftp. In this case, the results do include a column for the IP address.

@jeremystretch
Copy link
Member

This was added for devices in #1561. We can add it for VMs too.

@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Oct 13, 2017
@darkstar
Copy link

Ah I see, yes, you are correct, that is indeed missing. I searched for an IP that's why I got a different result

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants