Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child Prefix Tab on Prefix page #1773

Closed
awfki opened this issue Dec 14, 2017 · 3 comments
Closed

Child Prefix Tab on Prefix page #1773

awfki opened this issue Dec 14, 2017 · 3 comments
Labels
type: feature Introduction of new functionality to the application

Comments

@awfki
Copy link

awfki commented Dec 14, 2017

Issue type

[X ] Feature request

Environment

  • Python version: 2.7
  • NetBox version: 2.2.4

Description

On the page for a Prefix (https://netbox/ipam/prefixes/7/) there are tabs for Prefix and IP Addresses. Please add an additional tab called "Child Prefixes" between those. The new tab should just link to the Child Prefixes table further down the same page.

Screenshot with arrows showing what I intend.

Reason is that dependent on window size the Child Prefixes list is often hidden so if the user doesn't know it's there they may jump into IP addresses and then wonder why the child prefix doesn't show up.

I don't believe any DB changes or library updates are needed.

@awfki
Copy link
Author

awfki commented Dec 14, 2017

Looking at whether I could solve my own problem and it looks like the HTML for the prefix page is here (prefix.html) but it references prefix_header.html and I don't see that file anywhere.

If someone wants to point it out I'll be happy to take a look and see if I can submit a PR. I haven't played with Django at all so it's very possible that it would be beyond me.

NM, I found it. I was looking in the wrong place.

@awfki awfki changed the title Child Prefix "Tab" Child Prefix Tab on Prefix page Dec 14, 2017
@ajaydeepsingh
Copy link

It's possible. Just add another tab to the top and instead of linking to a different page, just have that new tab link to the start of the Child Prefixes section.
screen shot 2017-12-14 at 1 21 01 pm

To get the new tab:
<li role="presentation"><a href="#child">Child Prefixes</a></li>

and then just add an id tag to that portion of the generated page:

<div class="col-md-12" id="child">

@jeremystretch
Copy link
Member

I originally added the child prefixes list to the main prefix view so that users wouldn't have to make a second request to view the children, but I like the idea of standardizing on using separate views for related objects.

@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Dec 20, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants