Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExceptionHandlingMiddleware prevents further handling of exceptions #2266

Closed
jeremystretch opened this issue Jul 24, 2018 · 0 comments
Closed
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

Issue type

[ ] Feature request
[x] Bug report
[ ] Documentation
[ ] Housekeeping

Environment

  • Python version: 3.5.2
  • NetBox version: 2.3.6

Description

NetBox employs custom middleware to help process exceptions and return custom error messages in response to some common problems (e.g. incorrect file system permissions). This middleware consumes all exceptions and renders the 500 response template directly. This prevents further processing of exceptions by log handlers such as AdminEmailHandler.

ExceptionHandlingMiddleware should be adapted so that it returns a response only if we want to render a custom error message.

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels Jul 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

1 participant