Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Color Picker for New 'Tag' Feature #2324

Closed
WilliamMarti opened this issue Aug 7, 2018 · 6 comments
Closed

Add Color Picker for New 'Tag' Feature #2324

WilliamMarti opened this issue Aug 7, 2018 · 6 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@WilliamMarti
Copy link

Environment

Python version: Python v3.5.2
NetBox version: v2.4.1

Proposed Functionality

Add Color picker, similar to what currently exists with 'Device Roles' already.

Use Case

Currently all tags have a grey background, would be helpful if we could more quickly visually discern which is which.

Database Changes

Assuming we need a new field for the Tag model.

External Dependencies

No new external dependencies required.

@jeremystretch
Copy link
Member

Assuming we need a new field for the Tag model.

We're actually using the stock Tag model from django-taggit. We would need to implement our own model inheriting from TagBase. Should be fairly straightforward with a migration though, I think.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Aug 7, 2018
@iDemonix
Copy link

Would this functionality be in the Django admin area, or within the Netbox UI itself?

@jeremystretch
Copy link
Member

@iDemonix it would be implemented in the regular frontend.

@tb-killa
Copy link
Contributor

tb-killa commented Jan 8, 2019

Doesn't we could use Select2 for this? We could use the "Multi-select boxes (pillbox)".

@lampwins
Copy link
Contributor

lampwins commented Jan 8, 2019

@tb-killa yes the UI portion will be taken care of by Select2. In fact this is already implemented in the select2-ui branch.

However, adding color to tags will require more effort and will be implemented after select2 in accordance with this issue.

@lampwins
Copy link
Contributor

Implemented in the develop-2.6 branch.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

5 participants