Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Hardware and Platform Manufacturers to allow Platforms by different vendors on hardware not produced by that vendor #2363

Closed
JNR8 opened this issue Aug 16, 2018 · 9 comments

Comments

@JNR8
Copy link

JNR8 commented Aug 16, 2018

Environment

  • Python version: 3.x (migrated to v3 yesterday so should be latest version)
  • NetBox version: 2.4.3

Proposed Functionality

Allow an additional Manufacturer to be selected for Platforms within a device. This would avoid the issue above and still limit the list of available Platforms to the select Manufacturer as originally requested in #1744

Use Case

Dell R630 device with Dell selected as the Manufacturer with VMWare ESXi Platform installed.

Database Changes

Possibly, as this would need a new field to be present on the Device form with the appropriate logic to filter our Platforms for that Manufacturer. but this may not need much, if any Db changes to achieve it.

External Dependencies

None that I know of.

@jeremystretch
Copy link
Member

I think the goal of allowing a platform to be associated with a manufacturer is specifically to enforce this limitation. In this case it would make sense to not treat VMware as a manufacturer, and simply refer to the platform as "VMware ESXi."

@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Aug 16, 2018
@JNR8
Copy link
Author

JNR8 commented Aug 17, 2018 via email

@jeremystretch
Copy link
Member

So I would have to create VMWare ESXi as a platform for all Manufacturers on which you run that platform? I.e HP and Dell amongst other.

Yes, because ESXi is not inherently bound to any particular manufacturer. This is contrast to a platform like Junos, which (typically) runs only on hardware manufactured by Juniper.

@jeremystretch jeremystretch removed the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Aug 17, 2018
@JNR8
Copy link
Author

JNR8 commented Aug 20, 2018

I would disagree there. Whilst some platforms are created by hardware vendors, a lot are not. In these cases they may be called something like "Software Vendors" or "Developers". I would suggest "Vendor" covers both hardware and software creators for all platform types. I can see why you have a Manufacturer type in NetBox, allowing for Device templates to be associated with a Hardware Manufacturer. But, in my experience, most Data Centers will predominantly have more devices with platforms not created by the hardware manufacturer than not. (i.e. Hypervisors, Windows, Linux, Unix Platforms running on a variety of different hardware types).

Currently creating Platforms with no associated Hardware Manufacturer undoes the change requested in #1744 by listing all platforms unrelated to the hardware selected.

To more accurately document platforms I believe removing their link to the hardware manufacturer field and instead creating a new field (called "platform vendor" for example) so that you can accurately document vendors for platforms, fulfill the requested function change in #1744 and allow for completely documenting all environment types.

Not being able to set a Vendor for soo many platforms sets my OCD twitching. It also seems to be at odds with creating a system to accurately document Data Center Environments.

@LuPo
Copy link
Contributor

LuPo commented Jan 24, 2019

Hello Jeremy, likewise many others I really do appreciate your job. I would like to reopen a conversation on this topic and ask you to consider this problem looking on network devices instead.
In our data centers we are putting a lot of whitebox/capable routers from different major networking manufacturers. Without referring here to any specific brand name, it seams that there is a big advantage in terms of automation and operations in using a single NOS on networking devices from different vendors.
Wouldn't it make sense to create a relationship of "one to many" between a "platform" and a "manufacturer"?

@timber-schroeder
Copy link

Just chiming in that I have the exact same issues and requests as other people above. We have a lot of switches from different manufacturers running the same NOS distribution. While it would be possible to just decouple the platform from the manufacturer, that feels like a subpar solution, especially for instances where there are multiple platforms from a single software vendor in use.

What would be nice is if we could have a new field for manufacturers that tells if they are vendors for software, hardware or both. This would decouple the hardware manufacturers from the platform, which are very often unrelated to each other. As it is, creating multiple identical platforms just so that we can add those platforms to devices of differing manufacturers is a hacky solution.

Ideally we could then store version information on platforms and tie in those platforms with the services (service templates?) on individual devices, but I feel that that should be a separate issue.

@mbaybarsk
Copy link

Yes this is really causing me a headache.

I have several Hyper-V clusters and the "devices" that make up the nodes of the clusters are "HP" and I can't select "Server 2016" as a platform because it's a Microsoft product. This makes no sense for servers, only for networking equipment.

@aventrax
Copy link

aventrax commented Oct 4, 2019

Same here, I have physical servers from HP (Manufacturer=HP) with Windows installed (Platform=Microsoft), but I replicate this on Netbox, really a pity :(

@Blackraz0r
Copy link

+1 Same Issue here.
Have multiple Servers from Dell, HP and some Whiteboxes running 2 V-Sphere cluster.

Would be nice to have the ability to put Dell as the Manu for the server, VMWare as the manu/dev/whatever of the Operating System.

unfortunately Jeremy never hat this case and/or rageclosed the thread after recieving 2 downvotes for his descision in :

So I would have to create VMWare ESXi as a platform for all Manufacturers on which you run that platform? I.e HP and Dell amongst other.

Yes, because ESXi is not inherently bound to any particular manufacturer. This is contrast to a platform like Junos, which (typically) runs only on hardware manufactured by Juniper.

so @jeremystretch maybe u like to reconsider to let the user decide (maybe via a setting) if he want to be dell or vmware the manufacturer of the operating system?

@lock lock bot locked as resolved and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants