Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsolePort and ConsoleServerPort disconnect generates inconsistent webhooks. #4614

Closed
karrots opened this issue May 9, 2020 · 4 comments
Closed
Assignees
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@karrots
Copy link

karrots commented May 9, 2020

Environment

  • Python version: 3.7.7
  • NetBox version: 2.8.3

Steps to Reproduce

  1. Disable any installed plugins by commenting out the PLUGINS setting in
    configuration.py.
  2. Create a device with a console port
  3. Create a device with a console server port
  4. Create webhook attached to DCIM > console server port
    4.1. Type: update
    4.2. Method PUT (though this doesn't matter)
  5. Navigate to either the console port or console server port and click the green connect button.
  6. Disconnect the two ports

Expected Behavior

  1. Single webhook invocation
  2. connected_endpoint, connection_status, and cable filled fully with data or fully null

Observed Behavior

Connect operation triggers 3 identical webhook invocations.

Remove cable operation triggered from the ConsolePort port will create 2 invocations the first showing update with cable set to null but still showing the connected_endpoint and connection_status with data.
The second showing connected_endpoint, connection_status, and cable as null (disconnected).

Remove cable operation triggered from the ConsoleServerPort port will cause one invocation with data showing cable and connected_endpoint but the connection_status still shows as connected.

@jeremystretch
Copy link
Member

Please specify the stable NetBox release on which this issue may be replicated.

@jeremystretch jeremystretch added the status: revisions needed This issue requires additional information to be actionable label May 11, 2020
@karrots
Copy link
Author

karrots commented May 11, 2020

v2.8.3

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application and removed status: revisions needed This issue requires additional information to be actionable labels May 12, 2020
@steffann steffann self-assigned this Jun 23, 2020
@jeremystretch
Copy link
Member

I need to revisit this for v2.10 now that #4900 has been completed.

@jeremystretch
Copy link
Member

This has been resolved as part of the work on #4900 for the upcoming v2.10 release.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

3 participants