Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #6925 Interfaces Table - bring back the visual aids from v2.9 #7767

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Fixes: #6925 Interfaces Table - bring back the visual aids from v2.9 #7767

merged 3 commits into from
Nov 11, 2021

Conversation

teixemf
Copy link
Contributor

@teixemf teixemf commented Nov 6, 2021

Fixes: #6925 Interfaces Table - bring back the visual aids from v2.9

Reduce the need of the columns "Management Only", "Enabled" and "Type" on the Interfaces table by adding some visual aids that were used on past versions (v2.9).

  1. Virtual Interfaces are distinguished by row color "primary ".
  2. Disabled Interfaces are distinguished by row color "danger".
  3. Keep Connected Interfaces distinguished by row color "success".
  4. Interface type distinguished by different icons before the interface name:
    • Management Only: wrench
    • LAG: reorder-horizontal
    • Virtual: circle
    • Wireless: wifi
    • Others: ethernet

jeremystretch
jeremystretch requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple minor tweaks.

netbox/dcim/tables/devices.py Outdated Show resolved Hide resolved
netbox/dcim/tables/devices.py Outdated Show resolved Hide resolved
@teixemf @jeremystretch
Apply suggestions from code review
251abdb 
Co-authored-by: Jeremy Stretch <jstretch@ns1.com>
@jeremystretch jeremystretch merged commit 6c28182 into netbox-community:develop Nov 11, 2021
@jeremystretch
Copy link
Member

Thanks @CironAkono!

jeremystretch added a commit that referenced this pull request Nov 11, 2021
@jeremystretch
Changelog for #7767
2f064cd
@teixemf teixemf deleted the FR6925 branch November 11, 2021 18:41
@jeremystretch jeremystretch mentioned this pull request Nov 12, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interfaces Table - bring back the visual aids from v2.9
2 participants
@teixemf @jeremystretch