Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance delete message #8551

Closed
PieterL75 opened this issue Feb 4, 2022 · 5 comments
Closed

Enhance delete message #8551

PieterL75 opened this issue Feb 4, 2022 · 5 comments
Labels
pending closure Requires immediate attention to avoid being closed for inactivity status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application

Comments

@PieterL75
Copy link
Contributor

PieterL75 commented Feb 4, 2022

NetBox version

v3.1.6

Feature type

Change to existing functionality

Proposed functionality

The message showing when deleting something, is pretty simple :
image

It would benefit to make this message more detailed and include what is being deleted.
If the deletion includes other objects to be deleted, then that should be included (like an IP is deleted when a device is deleted; interfaces are deleted when a devicemodule is deleted)

Use case

Adding more details will prevent accidental deletions

Database changes

None

External dependencies

No response

@PieterL75 PieterL75 added the type: feature Introduction of new functionality to the application label Feb 4, 2022
@jeremystretch
Copy link
Member

Adding more details will prevent accidental deletion of cables

What makes cables different from any other object in this respect?

@PieterL75
Copy link
Contributor Author

Maybe increasing the scope to all delete messages ?
We do have quite some 'accidental' deletes, because the messages are pretty simple.

I catched the toughest ones by removing the delete rights (devices, prefixes, vlangroups, ...)
But I guess everyone would benefit from being able to review what they will delete in a glance.
Also the inherited deletions (Like IP addresses when deleting a device) would be very nice too see

@PieterL75 PieterL75 changed the title Enhance cable delete message Enhance delete message Mar 10, 2022
@PieterL75
Copy link
Contributor Author

I changed the scope of the FR to all delete messages rather then only the 'cable' delete message

@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Mar 30, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label May 30, 2022
@github-actions
Copy link
Contributor

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending closure Requires immediate attention to avoid being closed for inactivity status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants