feat: store reconciliation errors in redis #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
|
Go test coverage
Total coverage: 83.7% |
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store reconciliation and any other errors occurred when processing ingested data in redis. This will allow us to retrieve ingestion logs and display meaningful details regarding failures.
Example:
{ "data_type": "dcim.device", "entity": { "Device": { "name": "Conference_Room_AP_02", "device_type": { "model": "Cisco Aironet 3802", "manufacturer": { "name": "Cisco" } }, "role": { "name": "Wireless_AP" }, "serial": "PQR456789012", "site": { "name": "HQ" }, "asset_tag": "" } }, "error": { "Message": "failed to apply change set", "Code": 400, "Details": { "change_set_id": "7667cf0a-6499-4312-ba39-e45118282e7f", "result": "failed", "errors": [ { "asset_tag": "asset_tag: Device with this Asset tag already exists.", "change_id": "be011399-17a9-47e8-ac25-16fdd35514f1" } ] } }, "ingestion_ts": 1723191515569084347, "producer_app_name": "csv-parser", "producer_app_version": "0.0.1", "request_id": "328491ce-b2c4-48d9-b8eb-9793ff9f32ef", "sdk_name": "diode-sdk-python", "sdk_version": "0.0.1", "state": 2 }Also improve logging:
{ "time": "2024-08-09T08:18:36.24933293Z", "level": "WARN", "msg": "failed to handle ingest request", "errors": [ "msg: failed to apply change set, code: 400, change set id: a4b65636-19fc-4001-ab4c-e2b582f48d47, result: failed, errors: [{\"asset_tag\":\"asset_tag: Device with this Asset tag already exists.\",\"change_id\":\"78cadf30-b75d-4c58-8f00-e4dc2bdb178b\"}]", "msg: failed to apply change set, code: 400, change set id: a8ce7d8e-20fb-4a52-873c-2c071ce5996b, result: failed, errors: [{\"asset_tag\":\"asset_tag: Device with this Asset tag already exists.\",\"change_id\":\"7646dbb9-511a-48da-9d2e-73eb8cae5a80\"}]", "msg: failed to apply change set, code: 400, change set id: 7a154db7-3ac8-4194-848d-bab64ed19089, result: failed, errors: [{\"asset_tag\":\"asset_tag: Device with this Asset tag already exists.\",\"change_id\":\"916cf2b9-0273-40c5-87ab-cdb3d8ee8bbe\"}]", "msg: failed to apply change set, code: 400, change set id: adccf83a-a651-48b8-81ec-3e3e574d7c59, result: failed, errors: [{\"asset_tag\":\"asset_tag: Device with this Asset tag already exists.\",\"change_id\":\"bcf5dca9-303b-493b-a098-4061bd670b2a\"}]", "msg: failed to apply change set, code: 400, change set id: 7667cf0a-6499-4312-ba39-e45118282e7f, result: failed, errors: [{\"asset_tag\":\"asset_tag: Device with this Asset tag already exists.\",\"change_id\":\"be011399-17a9-47e8-ac25-16fdd35514f1\"}]" ] }