feat: reorg proto structure #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep diode related protobuf definitions (ingester and reconciler) under diode-proto directory and diode.v1 package Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
|
Go test coverage
Total coverage: 80.3% |
leoparente
reviewed
Aug 29, 2024
leoparente
reviewed
Aug 29, 2024
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
mfiedorowicz
changed the title
leoparente
reviewed
Aug 30, 2024
# Conflicts: # Makefile
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
github-actions
bot
added
documentation
leoparente
approved these changes
Aug 30, 2024
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diode.v1packagenetboxlabs/diode-sdk-go(same existingdiodepbgo package) removing same code being generated into go sdk and diode-server internallydiode-server/reconciler/v1/reconcilerpb(as-is)