Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store generated changeset into ingestion log #172

Merged
merged 9 commits into from
Sep 20, 2024
Merged

feat: store generated changeset into ingestion log #172

merged 9 commits into from
Sep 20, 2024

Conversation

leoparente
Copy link
Contributor

@leoparente leoparente commented Sep 19, 2024 •
edited
Loading

image

@leoparente leoparente self-assigned this Sep 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.22s github.com/netboxlabs/diode/diode-server/ingester 4.3% 9 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.57s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 3.2% 40 0 0
🟢 PASS 1.44s github.com/netboxlabs/diode/diode-server/reconciler 12.3% 59 0 0
🟢 PASS 1.46s github.com/netboxlabs/diode/diode-server/reconciler/changeset 34.2% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 80.0%

@leoparente leoparente marked this pull request as ready for review September 19, 2024 17:43
mfiedorowicz
mfiedorowicz approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoparente leoparente merged commit 44e1bcd into develop Sep 20, 2024
7 checks passed
@leoparente leoparente deleted the feat/OBS-524-store-changeset-into-logs branch September 20, 2024 18:15
@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@orb-ci
Copy link

orb-ci commented Sep 26, 2024

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

Assignees

@leoparente leoparente

Labels
dependencies diode-proto diode-reconciler diode-server go released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leoparente @orb-ci @mfiedorowicz