Error syncing new cable to branch

[jams1077]

Plugin Version

0.5.1

NetBox Version

4.1.3

Python Version

3.10.12

Steps to Reproduce

1. Create Devices A and B with interfaces
2. Create a new branch
3. On the Main branch, create a cable between device A interface and device B interface
4. On the new branch sync changes

Expected Behavior

All changes behind should have synced with the new branch

Observed Behavior

Sync operation fails with error:

"Creating cable <DeserializedObject: dcim.Cable(pk=300)>",
"{'__all__': ['Must define A and B terminations when creating a new cable.']}"

[jams1077]

Commenting out instance.object.full_clean() (line 42) in netbox_branching/models/changes.py solves the issue, but I don't know what implications removing this line could have.

[RedLine89]

Facing the same issue. It also fails to merge cable changes from a branch into main with the same error.

[jeremystretch]

I think this is caused by a recent change to NetBox, #17577. Changing the evaluation logic from self.pk is None to self._state.adding is True has a subtle implication for this plugin: We want to skip this specific validation rule because in the case of syncing an object, we know that any cable terminations have already been validated.

[jams1077]

thanks @jeremystretch