cleanup

Author: arthanson

netbox_custom_objects/api/serializers.py

@@ -230,9 +230,7 @@ def get_url(self, obj):
             "pk": lookup_value,
             "custom_object_type": obj.custom_object_type.name.lower(),
         }
-        request = self.context.get("request")
-        if not request:
-            return None
+        request = self.context["request"]
         format = self.context.get("format")
         return reverse(view_name, kwargs=kwargs, request=request, format=format)
 
@@ -250,83 +248,12 @@ def get_display(self, obj):
         "get_display": get_display,
     }
 
-    # Add custom fields using the proper field types
     for field in model_fields:
+        field_type = field_types.FIELD_TYPE_CLASS[field.type]()
         try:
-            field_type = field_types.FIELD_TYPE_CLASS[field.type]()
-            serializer_field = field_type.get_serializer_field(field)
-            
-            # Handle hyperlinked fields that might cause issues
-            if hasattr(serializer_field, 'view_name'):
-                # Check if the view_name is empty or problematic
-                if not getattr(serializer_field, 'view_name', None):
-                    # Replace with a safer field type
-                    if field.type in ['object', 'multiobject']:
-                        # Use PrimaryKeyRelatedField for object fields
-                        if hasattr(field, 'related_object_type') and field.related_object_type:
-                            try:
-                                model_class = field.related_object_type.model_class()
-                                if field.type == 'multiobject':
-                                    attrs[field.name] = serializers.PrimaryKeyRelatedField(
-                                        queryset=model_class.objects.all(),
-                                        many=True,
-                                        allow_null=True,
-                                        required=not field.required
-                                    )
-                                else:
-                                    attrs[field.name] = serializers.PrimaryKeyRelatedField(
-                                        queryset=model_class.objects.all(),
-                                        allow_null=True,
-                                        required=not field.required
-                                    )
-                            except Exception:
-                                # Fallback to read-only PK field
-                                attrs[field.name] = serializers.PrimaryKeyRelatedField(read_only=True)
-                        else:
-                            attrs[field.name] = serializers.PrimaryKeyRelatedField(read_only=True)
-                    else:
-                        attrs[field.name] = serializer_field
-                else:
-                    attrs[field.name] = serializer_field
-            else:
-                attrs[field.name] = serializer_field
-                
+            attrs[field.name] = field_type.get_serializer_field(field)
         except NotImplementedError:
             print(f"serializer: {field.name} field is not implemented; using a default serializer field")
-            # Create a basic field based on type
-            if field.type in ['text', 'longtext', 'url']:
-                attrs[field.name] = serializers.CharField(
-                    required=field.required, 
-                    allow_blank=not field.required,
-                    max_length=255 if field.type == 'text' else None
-                )
-            elif field.type == 'integer':
-                attrs[field.name] = serializers.IntegerField(required=field.required)
-            elif field.type == 'decimal':
-                attrs[field.name] = serializers.DecimalField(
-                    required=field.required, 
-                    max_digits=10, 
-                    decimal_places=2
-                )
-            elif field.type == 'boolean':
-                attrs[field.name] = serializers.BooleanField(required=field.required)
-            elif field.type == 'date':
-                attrs[field.name] = serializers.DateField(required=field.required)
-            elif field.type == 'datetime':
-                attrs[field.name] = serializers.DateTimeField(required=field.required)
-            else:
-                attrs[field.name] = serializers.CharField(
-                    required=field.required, 
-                    allow_blank=not field.required
-                )
-        except Exception as e:
-            print(f"serializer: Error creating field {field.name}: {e}")
-            # Safe fallback
-            attrs[field.name] = serializers.CharField(
-                required=False, 
-                allow_blank=True, 
-                read_only=True
-            )
 
     serializer_name = f"{model._meta.object_name}Serializer"
     serializer = type(
@@ -339,11 +266,4 @@ def get_display(self, obj):
     current_module = sys.modules[__name__]
     setattr(current_module, serializer_name, serializer)
 
-    '''    
-    # Also add to __all__ so it's properly exported
-    global __all__
-    if serializer_name not in __all__:
-        __all__ = __all__ + (serializer_name,)
-    '''    
-
     return serializer

netbox_custom_objects/models.py

@@ -485,10 +485,6 @@ def create_model(self):
         ct.features = features
         ct.save()
 
-        # Register the serializer for this model so NetBox's event system can find it
-        from netbox_custom_objects.api.serializers import get_serializer_class
-        get_serializer_class(model)
-
         with connection.schema_editor() as schema_editor:
             schema_editor.create_model(model)