Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Ability to remove nodes from "All nodes" room settings #1012

Open
M4itee opened this issue May 2, 2024 · 1 comment
Open

[Feat]: Ability to remove nodes from "All nodes" room settings #1012

M4itee opened this issue May 2, 2024 · 1 comment

Comments

@M4itee
Copy link

M4itee commented May 2, 2024

Problem

Nodes in All nodes room that are offline have to be deleted from Space settings instead of room settings.

Description

The main problem with this is that it is hard to remember about such twist in node management. Naturally since I'm browsing a particular room, I would like to adjust it's nodes from room settings - like with any other room.

Importance

really want

Value proposition

  1. UI is going to be more intuitive

Proposed implementation

Move the tab for removing nodes from Space settings to All nodes room.

@ralphm
Copy link
Member

ralphm commented May 2, 2024

Alternative suggestion: show a grayed out version of the remove-from-room button with a tooltip that suggests removal from the space settings.

Reasoning:

  • This makes the UI consistent between rooms without overloading the All Nodes room with more space-level functions.
  • The All Nodes room is really a type of room with dynamic membership. Once we get to have [https://github.com/[Feat]: Automated War Rooms #918], All Nodes will be just an instance of this.
  • The space settings allow for quickly removing more than one node.

Note

The All Nodes room is a special case because we needed a place to put nodes that weren't explicitly assigned to another room. It is currently also the place where you get to see audit type events. For large numbers of nodes, the metrics tab will eventually hit some limits, technically, in terms of usefulness, as well as cognitive utility. There is some consensus on the concept of an All Nodes room not being ideal, but we haven't come up with a decent alternative yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants