Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Outdated Troubleshooting Documentation for 'postgres_db_transactions_rollback_ratio' Metric #1044

Open
GGontijo opened this issue Oct 1, 2024 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@GGontijo
Copy link

GGontijo commented Oct 1, 2024

Bug description

Hi there!

I noticed that the troubleshooting documentation for the postgres_db_transactions_rollback_ratio metric seems to be outdated. In particular, the total_time field in the query should be updated to use (total_plan_time + total_exec_time) AS total_time. I found a similar issue in prometheus-community/postgres_exporter#541, which helped point me to the solution, but it's not an official fix related to PostgreSQL or the exporter itself.

I'm opening this as a bug because I couldn't find a dedicated section for documentation-related issues, nor did I see where I could contribute directly to update it. I just want to help improve the documentation and make sure it's accurate for everyone.

Thanks for all your hard work on Netdata! Let me know if I can assist further.

Best regards!

Expected behavior

The troubleshooting documentation for the postgres_db_transactions_rollback_ratio metric should provide the correct query. Instead of using the current total_time field, it should be updated to use (total_plan_time + total_exec_time) AS total_time.

Steps to reproduce

Ensure that the pg_stat_statements extension is installed and activated in PostgreSQL, using version 1.10.
The PostgreSQL version in use is 16.2.

Use the provided query in the troubleshooting documentation for the postgres_db_transactions_rollback_ratio metric.
Observe that the query still uses total_time instead of the recommended calculation (total_plan_time + total_exec_time).

Screenshots

Uploading Netdata Console - Google Chrome.jpg…

Error Logs

Uploading image.png…

Desktop

OS: Debian 12.2.0-14
Browser: Chrome
Browser Version: 129

Additional context

No response

@GGontijo GGontijo added bug Something isn't working needs triage labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

1 participant