Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Custom dashboards require saving even when there are no changes performed #857

Closed
dimko opened this issue Jun 22, 2023 · 1 comment

Comments

@dimko
Copy link

dimko commented Jun 22, 2023

Bug description

After visiting dashboards tab and opening a custom dashboard for save, we prompt the user to save the changes even when there are no changes performed to the dasboard, user cannot change tabs and leave this view if he doesn't dismiss the save work popup

Expected behavior

No changes to custom dashboards shouldn't require saving

Steps to reproduce

  1. Navigate to Netdata Cloud
  2. Switch to Dashboards tab
  3. open an existing custom dashboard (create one if nothing exists)
  4. Leave the page without performing any changesn

Screenshots

No response

Error Logs

No response

Desktop

OS: Macos
Browser Chrome
Browser Version 113

Additional context

No response

@dimko dimko added bug Something isn't working needs triage labels Jun 22, 2023
@dimko dimko changed the title [Bug]: Custom dashboards asks for Save even when there are no changes performed [Bug]: Custom dashboards ask for Save even when there are no changes performed Jun 22, 2023
@dimko dimko changed the title [Bug]: Custom dashboards ask for Save even when there are no changes performed [Bug]: Custom dashboards require saving even when there are no changes performed Jun 22, 2023
@novykh novykh self-assigned this Aug 12, 2023
@novykh
Copy link
Contributor

novykh commented Aug 12, 2023

Fixed.

@novykh novykh closed this as completed Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants